From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CC9EB64DC for ; Tue, 11 Jul 2023 12:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbjGKMwN (ORCPT ); Tue, 11 Jul 2023 08:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbjGKMwJ (ORCPT ); Tue, 11 Jul 2023 08:52:09 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BB898; Tue, 11 Jul 2023 05:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689079928; x=1720615928; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fixFH5Llqroff/AhZ015VZ+OpUUgSBQ7xNlXodB8idQ=; b=nXYGAZBmCt/q8vpk2hgdP5RxkOpR8+FWs2GpP++Xb4iPebpuW50dI6ld HDfRX3kjPZuoHIK0bhysXuedh2zVn1qePdMpdhmLGXnkzqtifn2r2mqWp FetdbMxf+0J+xg092E4vnYifUT0n/G0bNNxd8El0uHSo/uR5nGibEno3L Jmh0DoL1JhHjgCOyThsiLu+Lx5951MOmIzweA3blnVnam/XYL+VDS5W11 d77TFNBBZMuDVEn8vhLIeozSC+mGf/A0CsbpYbEWuVsf4ImS0A7BtfzGh zVehqdLyudfgZdv4w01fC+A1Q9qoiUkiVu3qCIUUXaR7zqL+C7FmjFewq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="344205663" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="344205663" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 05:52:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="786613329" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="786613329" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 11 Jul 2023 05:51:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJCqO-001qnp-39; Tue, 11 Jul 2023 15:51:52 +0300 Date: Tue, 11 Jul 2023 15:51:52 +0300 From: Andy Shevchenko To: AngeloGioacchino Del Regno Cc: Mark Brown , Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 01/15] spi: Remove unneeded OF node NULL checks Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 10:12:55AM +0200, AngeloGioacchino Del Regno wrote: > Il 10/07/23 17:49, Andy Shevchenko ha scritto: > > In the couple of places the NULL check of OF node is implied by the call > > that takes it as a parameter. Drop the respective duplicate checks. > > > > Signed-off-by: Andy Shevchenko > > Validated against spi-mt65xx, spi-mt7621, spi-mtk-nor, spi-mtk-snfi; > > Reviewed-by: AngeloGioacchino Del Regno > # MediaTek By some reason the tag is split and I'm not sure `b4` can cope with that. In any case, added manually. Thank you for the review! -- With Best Regards, Andy Shevchenko