From: Simon Horman <simon.horman@corigine.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/3] net: mscc: ocelot: extend ocelot->fwd_domain_lock to cover ocelot->tas_lock
Date: Tue, 11 Jul 2023 17:56:37 +0100 [thread overview]
Message-ID: <ZK2JxXusoKjkZq2m@corigine.com> (raw)
In-Reply-To: <20230705104422.49025-2-vladimir.oltean@nxp.com>
On Wed, Jul 05, 2023 at 01:44:20PM +0300, Vladimir Oltean wrote:
> In a future commit we will have to call vsc9959_tas_guard_bands_update()
> from ocelot_port_update_active_preemptible_tcs(), and that will be
> impossible due to the AB/BA locking dependencies between
> ocelot->tas_lock and ocelot->fwd_domain_lock.
>
> Just like we did in commit 3ff468ef987e ("net: mscc: ocelot: remove
> struct ocelot_mm_state :: lock"), the only solution is to expand the
> scope of ocelot->fwd_domain_lock for it to also serialize changes made
> to the Time-Aware Shaper, because those will have to result in a
> recalculation of cut-through TCs, which is something that depends on the
> forwarding domain.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-07-11 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 10:44 [PATCH net 0/3] Fix dropping of oversize preemptible frames with felix DSA driver Vladimir Oltean
2023-07-05 10:44 ` [PATCH net 1/3] net: mscc: ocelot: extend ocelot->fwd_domain_lock to cover ocelot->tas_lock Vladimir Oltean
2023-07-11 16:56 ` Simon Horman [this message]
2023-07-05 10:44 ` [PATCH net 2/3] net: dsa: felix: make vsc9959_tas_guard_bands_update() visible to ocelot->ops Vladimir Oltean
2023-07-05 10:44 ` [PATCH net 3/3] net: mscc: ocelot: fix oversize frame dropping for preemptible TCs Vladimir Oltean
2023-07-07 2:20 ` [PATCH net 0/3] Fix dropping of oversize preemptible frames with felix DSA driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK2JxXusoKjkZq2m@corigine.com \
--to=simon.horman@corigine.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox