From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB06C001B0 for ; Tue, 11 Jul 2023 22:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbjGKWL7 (ORCPT ); Tue, 11 Jul 2023 18:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjGKWL4 (ORCPT ); Tue, 11 Jul 2023 18:11:56 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 070411BD7 for ; Tue, 11 Jul 2023 15:11:27 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b52875b8d9so66765ad.0 for ; Tue, 11 Jul 2023 15:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689113487; x=1691705487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EHo0qMf4X1AE4fyMbmdJ4zDFrUO5AckTUAmIVNX3n3g=; b=bfZUezdR6ChxnnxVGsBAilrCjBS5n76CuxktV8rcb2pcv/iqsYDm1kigi7cfmzReQu MxKM6KU1x8k4rBHgYTBBVeVR/EaKKBZUZU+WrKJJuXjUPV8GWe3fqdc4HEC57iefR5nV 1BXmo2dcwW2j9jvDj0AA+XRR/ODoei+4k0Mx8x1HAlYvjL3raftlIctYj/zuqocHBJ6D Hp5TlpKTG6IENYTKIjvWdg49gnzvpFgJyEdWba08B6bgvMft4nNuoV0VZtcZNfXRj0Gm 1ME2PQgm9azlZEx1S8PBu1N27cajbrj9BrAbWY05Nk5N22GGa1PfG7dn4emM4gT6UBi5 bwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689113487; x=1691705487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EHo0qMf4X1AE4fyMbmdJ4zDFrUO5AckTUAmIVNX3n3g=; b=RXTpWKBveZGPXH/AoujaYzaWwPXYe7MW2w2dgMlX+8Vc3s3IjFPedpEdH0jPD930T9 kOx0CKb6FFLQPwThucuTvrUGdPZkuuJYaF9Mksw3oV7LiontonzzO2YmthUCvkYNRGc9 Ug+rI5HsekludFpf4NI+KgNwzBUVRXC9jHEO1qRZhkWNo4efX+A3qExACC8JRZmB8E8r Cf2jDeF7cjXbhV7s0pZWqG+t+vp4VbE7YnGOg/QT4dw9WDdcJJBsCpbUBdEycEUpQz35 dWQpnM5MuBp7teVt1RMBY3iIee6z+da3wLC0MBfvz+djI1sfwRt3ClKoYweSXxST/R81 4ggA== X-Gm-Message-State: ABy/qLYCyRMjwsyMAQ0iQKX/Pv0fgXJgnFA/PbnFqA3HoD4nVupuoD9a 8kbQ3pU6I6H335pPCR3u35/nxg== X-Google-Smtp-Source: APBJJlHqZ0qfiC4zcfhS1XF3OMF9UVOH+LxsU51wscEEc3H0iT4AUmhd8wDhsXS45SiLuMmywDpiFQ== X-Received: by 2002:a17:902:f688:b0:1b8:c666:1fc1 with SMTP id l8-20020a170902f68800b001b8c6661fc1mr88703plg.20.1689113487138; Tue, 11 Jul 2023 15:11:27 -0700 (PDT) Received: from google.com ([2620:15c:2d:3:8944:7c0b:5d4e:f65b]) by smtp.gmail.com with ESMTPSA id x22-20020aa79196000000b00682a839d0aesm2181015pfa.112.2023.07.11.15.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 15:11:26 -0700 (PDT) Date: Tue, 11 Jul 2023 15:11:22 -0700 From: Isaac Manjarres To: Mark Brown Cc: Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , "Russell King (Oracle)" , Saravana Kannan , Tomeu Vizoso , Ulf Hansson , Marek Szyprowski , Aidan MacDonald , Amit Pundir , John Stultz , stable@vger.kernel.org, Catalin Marinas , kernel-team@android.com, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] regmap-irq: Fix out-of-bounds access when allocating config buffers Message-ID: References: <20230711193059.2480971-1-isaacmanjarres@google.com> <8e5fba54-9ec7-45a7-8dd6-6ea63d853907@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e5fba54-9ec7-45a7-8dd6-6ea63d853907@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 08:50:08PM +0100, Mark Brown wrote: > On Tue, Jul 11, 2023 at 12:30:58PM -0700, Isaac J. Manjarres wrote: > > > [ 14.033877][ T1] ================================================================== > > [ 14.042507][ T1] BUG: KASAN: invalid-access in regmap_add_irq_chip_fwnode+0x594/0x1364 > > [ 14.050796][ T1] Write of size 8 at addr 06ffff8081021850 by task init/1 > > [ 14.057841][ T1] Pointer tag: [06], memory tag: [fe] > > [ 14.063124][ T1] > > [ 14.065349][ T1] CPU: 2 PID: 1 Comm: init Tainted: G W E 6.4.0-mainline-g6a4b67fef3e2 #1 > > [ 14.075014][ T1] Hardware name: Thundercomm Dragonboard 845c (DT) > > [ 14.081432][ T1] Call trace: > > Please think hard before including complete backtraces in upstream > reports, they are very large and contain almost no useful information > relative to their size so often obscure the relevant content in your > message. If part of the backtrace is usefully illustrative (it often is > for search engines if nothing else) then it's usually better to pull out > the relevant sections. Hi Mark, Thanks for your feedback. I'll go ahead and send out a new version of the patch with a trimmed down commit message. Thanks, Isaac