* [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error
@ 2023-07-11 7:24 Krzysztof Kozlowski
2023-07-12 18:53 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-11 7:24 UTC (permalink / raw)
To: Dmitry Torokhov, Krzysztof Kozlowski, Hans de Goede,
Andy Shevchenko, linux-input, linux-kernel
Cc: kernel test robot, Dan Carpenter
Pass proper PTR_ERR as dev_err_probe() argument.
Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/input/keyboard/bcm-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
index 05b09066df84..bcc480ff7c3b 100644
--- a/drivers/input/keyboard/bcm-keypad.c
+++ b/drivers/input/keyboard/bcm-keypad.c
@@ -367,7 +367,7 @@ static int bcm_kp_probe(struct platform_device *pdev)
/* Enable clock */
kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk");
if (IS_ERR(kp->clk)) {
- return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
+ return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n");
} else if (!kp->clk) {
dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n");
} else {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error
2023-07-11 7:24 [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error Krzysztof Kozlowski
@ 2023-07-12 18:53 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-07-12 18:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Hans de Goede, Andy Shevchenko, linux-input, linux-kernel,
kernel test robot, Dan Carpenter
On Tue, Jul 11, 2023 at 09:24:49AM +0200, Krzysztof Kozlowski wrote:
> Pass proper PTR_ERR as dev_err_probe() argument.
>
> Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-12 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 7:24 [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error Krzysztof Kozlowski
2023-07-12 18:53 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox