From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D023FC001E0 for ; Wed, 12 Jul 2023 23:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232014AbjGLXSP (ORCPT ); Wed, 12 Jul 2023 19:18:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233477AbjGLXSI (ORCPT ); Wed, 12 Jul 2023 19:18:08 -0400 Received: from mx.treblig.org (unknown [IPv6:2a00:1098:5b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 662DF11D; Wed, 12 Jul 2023 16:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=5mUxfgJDdckbP7JIrFh96lrJMsGTOSdHCH5f/f6iXKI=; b=H/xd/EKZwwwRnmzUWi1/zQisH2 EsVVAAe02P5WKT4gqRhUbexi1RsHzNExjO2c5HtLJ6vKe6rC1aOc6zM2vzG8hmbcZWy1KxtzThe56 slzKtID9BLsrkudsFh4OxH9IkdP27Pi3s6cxj3f0RjD4lOhSfGKDibpkBQzJps16zvsvNrdELdR9l t0utAgVFxtOCWMFY1K/KdV6zEr2VLfqZOS9llfQjD0UknQm9Xby01/uj/s2ybFW+FXKeJZSU/FxEI ow4sNWPl8bVcQ0tCmRLbtx1GiMrAyko1r8kiz9EbeaHvd1A7ZPjUgUhrtCIhgucw2jhyXkfdfCVWp kCQqKrYQ==; Received: from dg by mx.treblig.org with local (Exim 4.94.2) (envelope-from ) id 1qJj5e-000zJZ-74; Wed, 12 Jul 2023 23:17:46 +0000 Date: Wed, 12 Jul 2023 23:17:46 +0000 From: "Dr. David Alan Gilbert" To: sfrench@samba.org, linkinjeon@kernel.org, tom@talpey.com, dave.kleikamp@oracle.com, shaggy@kernel.org, linux-cifs@vger.kernel.org Cc: krisman@collabora.com, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] dedupe smb unicode files Message-ID: References: <20230628232417.120844-1-linux@treblig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20230628232417.120844-1-linux@treblig.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/5.10.0-23-amd64 (x86_64) X-Uptime: 23:16:20 up 6 days, 8:47, 1 user, load average: 0.05, 0.03, 0.00 User-Agent: Mutt/2.0.5 (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * linux@treblig.org (linux@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > The smb client and server code have (mostly) duplicated code > for unicode manipulation, in particular upper case handling. > > Flatten this lot into shared code. Gentle two week ping on this please. Dave (Apologies to the 3 of you who already got a copy of this ping, recent due to a missing header ',' ) > There's some code that's slightly different between the two, and > I've not attempted to share that - this should be strictly a no > behaviour change set. > > In addition, the same tables and code are shared in jfs, however > there's very little testing available for the unicode in there, > so just share the raw data tables. > > I suspect there's more UCS-2 code that can be shared, in the NLS code > and in the UCS-2 code used by the EFI interfaces. > > Lightly tested with a module and a monolithic build, and just mounting > itself. > > This dupe was found using PMD: > https://pmd.github.io/pmd/pmd_userdocs_cpd.html > > Dave > > Version 2 > Moved the shared code to fs/nls after v1 feedback. > Renamed shared tables from Smb to Nls prefix > Move UniStrcat as well > Share the JFS tables > > Dr. David Alan Gilbert (4): > fs/smb: Remove unicode 'lower' tables > fs/smb: Swing unicode common code from smb->NLS > fs/smb/client: Use common code in client > fs/jfs: Use common ucs2 upper case table > > fs/jfs/Kconfig | 1 + > fs/jfs/Makefile | 2 +- > fs/jfs/jfs_unicode.h | 17 +- > fs/jfs/jfs_uniupr.c | 121 ------------- > fs/nls/Kconfig | 8 + > fs/nls/Makefile | 1 + > fs/nls/nls_ucs2_data.h | 15 ++ > fs/nls/nls_ucs2_utils.c | 144 +++++++++++++++ > fs/nls/nls_ucs2_utils.h | 285 ++++++++++++++++++++++++++++++ > fs/smb/client/Kconfig | 1 + > fs/smb/client/cifs_unicode.c | 1 - > fs/smb/client/cifs_unicode.h | 330 +---------------------------------- > fs/smb/client/cifs_uniupr.h | 239 ------------------------- > fs/smb/server/Kconfig | 1 + > fs/smb/server/unicode.c | 1 - > fs/smb/server/unicode.h | 325 +--------------------------------- > fs/smb/server/uniupr.h | 268 ---------------------------- > 17 files changed, 467 insertions(+), 1293 deletions(-) > delete mode 100644 fs/jfs/jfs_uniupr.c > create mode 100644 fs/nls/nls_ucs2_data.h > create mode 100644 fs/nls/nls_ucs2_utils.c > create mode 100644 fs/nls/nls_ucs2_utils.h > delete mode 100644 fs/smb/client/cifs_uniupr.h > delete mode 100644 fs/smb/server/uniupr.h > > -- > 2.41.0 > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/