From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v1 1/2] docs: printk-formats: Fix hex printing of signed values
Date: Mon, 3 Jul 2023 18:08:33 +0300 [thread overview]
Message-ID: <ZKLkcWyY35OK/ZTw@smile.fi.intel.com> (raw)
In-Reply-To: <20230703145839.14248-1-andriy.shevchenko@linux.intel.com>
On Mon, Jul 03, 2023 at 05:58:38PM +0300, Andy Shevchenko wrote:
> The commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]") obviously missed the point of sign
> promotion for the signed values lesser than int. In such case %x prints
> not the same as %h[h]x. Restore back those specifiers for the signed hex
> cases.
FWIW, currently we luckily have only one ABI case
drivers/power/supply/bq24190_charger.c:466
which luckily uses unsigned value for that specifier.
The rest is debug and error messages along with tracepoints.
The tracepoints might have an undesired, but not critical,
deviation. Nevertheless, promoting sign for hex values seems
to me the wrong suggestion.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-03 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 14:58 [PATCH v1 1/2] docs: printk-formats: Fix hex printing of signed values Andy Shevchenko
2023-07-03 14:58 ` [PATCH v1 2/2] docs: printk-formats: Treat char as always unsigned Andy Shevchenko
2023-07-14 15:34 ` Petr Mladek
2023-07-14 16:04 ` Andy Shevchenko
2023-07-18 11:46 ` Petr Mladek
2023-07-03 15:08 ` Andy Shevchenko [this message]
2023-07-14 15:32 ` [PATCH v1 1/2] docs: printk-formats: Fix hex printing of signed values Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKLkcWyY35OK/ZTw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox