From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62395C001B0 for ; Mon, 3 Jul 2023 21:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbjGCVcK (ORCPT ); Mon, 3 Jul 2023 17:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230421AbjGCVcG (ORCPT ); Mon, 3 Jul 2023 17:32:06 -0400 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDCF51A7 for ; Mon, 3 Jul 2023 14:32:05 -0700 (PDT) Received: from localhost (88-113-24-87.elisa-laajakaista.fi [88.113.24.87]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 0d41d9fc-19e9-11ee-abf4-005056bdd08f; Tue, 04 Jul 2023 00:32:03 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 4 Jul 2023 00:32:03 +0300 To: Mario Limonciello Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com, linus.walleij@linaro.org, npliashechnikov@gmail.com, nmschulte@gmail.com, friedrich.vock@gmx.de, dridri85@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] pinctrl: amd: Drop pull up select configuration Message-ID: References: <20230630194716.6497-1-mario.limonciello@amd.com> <20230630194716.6497-3-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230630194716.6497-3-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fri, Jun 30, 2023 at 02:47:14PM -0500, Mario Limonciello kirjoitti: > pinctrl-amd currently tries to program bit 19 of all GPIOs to select > either a 4kΩ or 8hΩ pull up, but this isn't what bit 19 does. Bit > 19 is marked as reserved, even in the latest platforms documentation. > > Drop this programming functionality. Can it be that documentation is not (yet) updated? Where, btw, did the original code come from? Perhaps it may shed some light on this. -- With Best Regards, Andy Shevchenko