From: andy.shevchenko@gmail.com
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
linus.walleij@linaro.org, npliashechnikov@gmail.com,
nmschulte@gmail.com, friedrich.vock@gmx.de, dridri85@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set()
Date: Tue, 4 Jul 2023 00:33:33 +0300 [thread overview]
Message-ID: <ZKM-rde5VyTScJHC@surfacebook> (raw)
In-Reply-To: <20230630194716.6497-4-mario.limonciello@amd.com>
Fri, Jun 30, 2023 at 02:47:15PM -0500, Mario Limonciello kirjoitti:
> Debounce handling is done in two different entry points in the driver.
> Unify this to make sure that it's always handled the same.
...
> -static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,
> - unsigned debounce)
> +static int amd_gpio_set_debounce(struct amd_gpio *gpio_dev, unsigned offset,
> + unsigned debounce)
Side note: Are you going to fix unsigned --> unsigned int?
The former is discouraged.
...
> +out:
out_unlock: ?
> raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
>
> return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-03 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:47 [PATCH 0/4] Fix for interrupt storm on ASUS TUF A16 Mario Limonciello
2023-06-30 19:47 ` [PATCH 1/4] pinctrl: amd: Only use special debounce behavior for GPIO 0 Mario Limonciello
2023-06-30 19:47 ` [PATCH 2/4] pinctrl: amd: Drop pull up select configuration Mario Limonciello
2023-07-03 21:32 ` andy.shevchenko
2023-07-04 2:13 ` Mario Limonciello
2023-06-30 19:47 ` [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set() Mario Limonciello
2023-07-03 21:33 ` andy.shevchenko [this message]
2023-07-04 2:16 ` Mario Limonciello
2023-06-30 19:47 ` [PATCH 4/4] pinctrl: amd: Use amd_pinconf_set() for all config options Mario Limonciello
2023-07-03 21:35 ` andy.shevchenko
2023-07-04 2:15 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKM-rde5VyTScJHC@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=dridri85@gmail.com \
--cc=friedrich.vock@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nmschulte@gmail.com \
--cc=npliashechnikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox