From: andy.shevchenko@gmail.com
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
linus.walleij@linaro.org, npliashechnikov@gmail.com,
nmschulte@gmail.com, friedrich.vock@gmx.de, dridri85@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] pinctrl: amd: Use amd_pinconf_set() for all config options
Date: Tue, 4 Jul 2023 00:35:42 +0300 [thread overview]
Message-ID: <ZKM_Ltif-L59Jo34@surfacebook> (raw)
In-Reply-To: <20230630194716.6497-5-mario.limonciello@amd.com>
Fri, Jun 30, 2023 at 02:47:16PM -0500, Mario Limonciello kirjoitti:
> On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to
> GPIO 7 is causing an interrupt storm. This issue doesn't happen on
> Windows.
>
> Comparing the GPIO register configuration between Windows and Linux
> bit 20 has been configured as a pull up on Windows, but not on Linux.
> Checking GPIO declaration from the firmware it is clear it *should* have
> been a pull up on Linux as well.
>
> ```
> GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000,
> "\\_SB.GPIO", 0x00, ResourceConsumer, ,
> )
> { // Pin list
> 0x0007
> }
I beleive we do not need so many heading spaces in the above
> ```
>
> On Linux amd_gpio_set_config() is currently only used for programming
> the debounce. Actually the GPIO core calls it with all the arguments
> that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`.
>
> To solve this issue expand amd_gpio_set_config() to support the other
> arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`,
> `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`.
...
> Fixes: 2956b5d94a76b ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
Can you group fixes at the beginning of the series?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-03 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:47 [PATCH 0/4] Fix for interrupt storm on ASUS TUF A16 Mario Limonciello
2023-06-30 19:47 ` [PATCH 1/4] pinctrl: amd: Only use special debounce behavior for GPIO 0 Mario Limonciello
2023-06-30 19:47 ` [PATCH 2/4] pinctrl: amd: Drop pull up select configuration Mario Limonciello
2023-07-03 21:32 ` andy.shevchenko
2023-07-04 2:13 ` Mario Limonciello
2023-06-30 19:47 ` [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set() Mario Limonciello
2023-07-03 21:33 ` andy.shevchenko
2023-07-04 2:16 ` Mario Limonciello
2023-06-30 19:47 ` [PATCH 4/4] pinctrl: amd: Use amd_pinconf_set() for all config options Mario Limonciello
2023-07-03 21:35 ` andy.shevchenko [this message]
2023-07-04 2:15 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKM_Ltif-L59Jo34@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=dridri85@gmail.com \
--cc=friedrich.vock@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nmschulte@gmail.com \
--cc=npliashechnikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox