From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E52FEB64DC for ; Mon, 3 Jul 2023 21:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbjGCVfr (ORCPT ); Mon, 3 Jul 2023 17:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjGCVfp (ORCPT ); Mon, 3 Jul 2023 17:35:45 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C35ED1A7 for ; Mon, 3 Jul 2023 14:35:44 -0700 (PDT) Received: from localhost (88-113-24-87.elisa-laajakaista.fi [88.113.24.87]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 8f925d03-19e9-11ee-b3cf-005056bd6ce9; Tue, 04 Jul 2023 00:35:42 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 4 Jul 2023 00:35:42 +0300 To: Mario Limonciello Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com, linus.walleij@linaro.org, npliashechnikov@gmail.com, nmschulte@gmail.com, friedrich.vock@gmx.de, dridri85@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] pinctrl: amd: Use amd_pinconf_set() for all config options Message-ID: References: <20230630194716.6497-1-mario.limonciello@amd.com> <20230630194716.6497-5-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630194716.6497-5-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fri, Jun 30, 2023 at 02:47:16PM -0500, Mario Limonciello kirjoitti: > On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to > GPIO 7 is causing an interrupt storm. This issue doesn't happen on > Windows. > > Comparing the GPIO register configuration between Windows and Linux > bit 20 has been configured as a pull up on Windows, but not on Linux. > Checking GPIO declaration from the firmware it is clear it *should* have > been a pull up on Linux as well. > > ``` > GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000, > "\\_SB.GPIO", 0x00, ResourceConsumer, , > ) > { // Pin list > 0x0007 > } I beleive we do not need so many heading spaces in the above > ``` > > On Linux amd_gpio_set_config() is currently only used for programming > the debounce. Actually the GPIO core calls it with all the arguments > that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`. > > To solve this issue expand amd_gpio_set_config() to support the other > arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`, > `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`. ... > Fixes: 2956b5d94a76b ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips") Can you group fixes at the beginning of the series? -- With Best Regards, Andy Shevchenko