Re: [PATCH] staging: rtl8192u: Fix assignment in if condition

Greg Kroah-Hartman
2023-07-04T12:32:00Z

On Tue, Jul 04, 2023 at 12:15:57PM +0000, wangjinchao wrote:
> I just participated in Outreachy of KernelNewbies and fixed one
> 'ERROR: do not use assignment in if condition' issue reported by
> checkpatch.pl on drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c.
>
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index ca09367005e1..52ff9e62ec08 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -1121,8 +1121,9 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
>
> /* skb: hdr + (possibly fragmented, possibly encrypted) payload */
>
> + keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt);
> if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) &&
> - (keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) {
> + keyidx < 0) {
> netdev_dbg(ieee->dev, "decrypt frame error\n");
> goto rx_dropped;
> }
> --
> 2.40.0
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.

- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot