From: Corey Minyard <minyard@acm.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Chengfeng Ye <dg573847474@gmail.com>
Subject: Re: [PATCH] ipmi: fix potential deadlock on &kcs_bmc->lock
Date: Tue, 4 Jul 2023 09:27:47 -0500 [thread overview]
Message-ID: <ZKQsY3DXXDbxy0om@mail.minyard.net> (raw)
In-Reply-To: <9691d898-22a9-4902-871d-73f5dafabf86@app.fastmail.com>
On Fri, Jun 30, 2023 at 10:31:02AM +0930, Andrew Jeffery wrote:
> Hi Corey, Chengfeng,
>
> On Wed, 28 Jun 2023, at 21:17, Corey Minyard wrote:
> > Indeed, this looks like an issue.
> >
> > Andrew, any opinions on this? The attached patch will work, the other
> > option would be to disable interrupts when calling
> > kcs_bmc_handle_event() in the timer handler. But then you have to worry
> > about RT.
>
> Right, I think we'd do best to not over-complicate things.
> spin_lock_irq{save,restore}() are the intuitive choice to me.
>
> I'll follow up with R-b/T-b tags once I've booted the patch
> and done some testing.
Thanks. This is in my for-next tree, I'd like to get this in the merge
window, which I believe ends this Sunday.
> >> This flaw was found using an experimental static analysis tool we are
> >> developing for irq-related deadlock.
Will this tool be available for general use? It's obviously quite
handy.
-corey
next prev parent reply other threads:[~2023-07-04 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 15:24 [PATCH] ipmi: fix potential deadlock on &kcs_bmc->lock Chengfeng Ye
2023-06-28 11:47 ` Corey Minyard
2023-06-30 1:01 ` Andrew Jeffery
2023-07-04 14:27 ` Corey Minyard [this message]
2023-07-04 16:25 ` Chengfeng Ye
2023-07-05 12:00 ` Andrew Jeffery
2023-07-19 18:37 ` Chengfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKQsY3DXXDbxy0om@mail.minyard.net \
--to=minyard@acm.org \
--cc=andrew@aj.id.au \
--cc=dg573847474@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox