* [PATCH v2 2/2] libbpf: fix some typo of hashmap init
@ 2023-07-10 5:56 John Sanpe
2023-07-10 17:24 ` Stanislav Fomichev
0 siblings, 1 reply; 4+ messages in thread
From: John Sanpe @ 2023-07-10 5:56 UTC (permalink / raw)
To: daniel, ast, andrii
Cc: martin.lau, song, yhs, john.fastabend, kpsingh, sdf, haoluo,
jolsa, bpf, linux-kernel, John Sanpe
Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
Signed-off-by: John Sanpe <sanpeqf@gmail.com>
---
tools/lib/bpf/hashmap.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/tools/lib/bpf/hashmap.h b/tools/lib/bpf/hashmap.h
index bae3feaf29d0..c12f8320e668 100644
--- a/tools/lib/bpf/hashmap.h
+++ b/tools/lib/bpf/hashmap.h
@@ -80,16 +80,6 @@ struct hashmap {
size_t sz;
};
-#define HASHMAP_INIT(_hash_fn, _equal_fn, _ctx) { \
- .hash_fn = (_hash_fn), \
- .equal_fn = (_equal_fn), \
- .ctx = (_ctx), \
- .buckets = NULL, \
- .cap = 0, \
- .cap_bits = 0, \
- .sz = 0, \
-}
-
void hashmap__init(struct hashmap *map, hashmap_hash_fn hash_fn,
hashmap_equal_fn equal_fn, void *ctx);
struct hashmap *hashmap__new(hashmap_hash_fn hash_fn,
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
2023-07-10 5:56 [PATCH v2 2/2] libbpf: fix some typo of hashmap init John Sanpe
@ 2023-07-10 17:24 ` Stanislav Fomichev
2023-07-10 21:12 ` Andrii Nakryiko
0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Fomichev @ 2023-07-10 17:24 UTC (permalink / raw)
To: John Sanpe
Cc: daniel, ast, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, haoluo, jolsa, bpf, linux-kernel
On 07/10, John Sanpe wrote:
> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>
> Signed-off-by: John Sanpe <sanpeqf@gmail.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Doesn't look like it was ever used.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
2023-07-10 17:24 ` Stanislav Fomichev
@ 2023-07-10 21:12 ` Andrii Nakryiko
2023-07-11 7:09 ` John Sanpe
0 siblings, 1 reply; 4+ messages in thread
From: Andrii Nakryiko @ 2023-07-10 21:12 UTC (permalink / raw)
To: Stanislav Fomichev
Cc: John Sanpe, daniel, ast, andrii, martin.lau, song, yhs,
john.fastabend, kpsingh, haoluo, jolsa, bpf, linux-kernel
On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> On 07/10, John Sanpe wrote:
> > Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
> >
> > Signed-off-by: John Sanpe <sanpeqf@gmail.com>
>
> Acked-by: Stanislav Fomichev <sdf@google.com>
>
> Doesn't look like it was ever used.
Ack for the change, but the subject doesn't correspond to the change
itself. You are not fixing typo, you are removing static
initialization helper.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
2023-07-10 21:12 ` Andrii Nakryiko
@ 2023-07-11 7:09 ` John Sanpe
0 siblings, 0 replies; 4+ messages in thread
From: John Sanpe @ 2023-07-11 7:09 UTC (permalink / raw)
To: Andrii Nakryiko, Stanislav Fomichev
Cc: daniel, ast, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, haoluo, jolsa, bpf, linux-kernel
On 7/11/23 05:12, Andrii Nakryiko wrote:
> On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev<sdf@google.com> wrote:
>> On 07/10, John Sanpe wrote:
>>> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>>>
>>> Signed-off-by: John Sanpe<sanpeqf@gmail.com>
>> Acked-by: Stanislav Fomichev<sdf@google.com>
>>
>> Doesn't look like it was ever used.
> Ack for the change, but the subject doesn't correspond to the change
> itself. You are not fixing typo, you are removing static
> initialization helper.
Thanks for your suggestion, I have merged the two commits and used a
more reasonable subject in v3:
https://lore.kernel.org/all/20230711070712.2064144-1-sanpeqf@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-11 7:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 5:56 [PATCH v2 2/2] libbpf: fix some typo of hashmap init John Sanpe
2023-07-10 17:24 ` Stanislav Fomichev
2023-07-10 21:12 ` Andrii Nakryiko
2023-07-11 7:09 ` John Sanpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox