public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hugo Villeneuve <hugo@hugovil.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] auxdisplay: hd44780: move cursor home after clear display command
Date: Tue, 25 Jul 2023 18:42:39 +0200	[thread overview]
Message-ID: <ZL/7f8Q6xnoJVakk@1wt.eu> (raw)
In-Reply-To: <CAMuHMdW0-FcDo-S_DGq+AkWkhB66n_VTow5v2riw8fwmknjddQ@mail.gmail.com>

On Tue, Jul 25, 2023 at 05:58:45PM +0200, Geert Uytterhoeven wrote:
> > One thing I'm having in mind is that this LCD supported horizontal
> > scrolling to show the off-screen columns. I'm wondering if the gotoxy()
> > and home() did the same thing regarding this. Maybe gotoxy() scrolled
> > back to 0,0 while home() just moved the cursor to the visible home
> > without scrolling back, in which case it could make a difference.
> 
> Indeed, at least according to the real HD44780 documentation,
> Return Home also resets the scrolling.

OK, thanks for checking!

> > I would suggest that we just stick to the specs and see if anyone reports
> > any trouble. There are so many compatible devices nowadays that possibly
> > implement only a subset of the original controller that we should really
> > stick to what is clearly understood by everyone and not rely on some old
> > conclusions about vague observations made by me 25 years ago!
> 
> OK. Given this patch is also a workaround for an incomplete
> implementation, let's keep hd44780_common_home() as-is.

OK, works for me.

Thanks,
Willy

  reply	other threads:[~2023-07-25 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22 18:09 [PATCH v2] auxdisplay: hd44780: move cursor home after clear display command Hugo Villeneuve
2023-07-24 16:08 ` Geert Uytterhoeven
2023-07-25 15:13   ` Hugo Villeneuve
2023-07-25 15:21     ` Geert Uytterhoeven
2023-07-25 15:36       ` Willy Tarreau
2023-07-25 15:58         ` Geert Uytterhoeven
2023-07-25 16:42           ` Willy Tarreau [this message]
2023-07-26 15:12 ` David Reaver
2023-08-19 19:58 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZL/7f8Q6xnoJVakk@1wt.eu \
    --to=w@1wt.eu \
    --cc=geert@linux-m68k.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox