From: Andy Shevchenko <andy@kernel.org>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com,
brgl@bgdev.pl, linus.walleij@linaro.org,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata()
Date: Tue, 25 Jul 2023 16:25:39 +0300 [thread overview]
Message-ID: <ZL/NUySYJnOrc5Qs@smile.fi.intel.com> (raw)
In-Reply-To: <ZLqf6P22HC0Dd4G5@smile.fi.intel.com>
On Fri, Jul 21, 2023 at 06:10:32PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 04:08:38PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.
Not true.
> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
I have to withdraw this, the patch is wrong.
NAK.
Sorry for the confusion (I have looked for the wrong pattern).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-25 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:08 [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata() Andrei Coardos
2023-07-21 15:10 ` Andy Shevchenko
2023-07-25 13:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL/NUySYJnOrc5Qs@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=angelogioacchino.delregno@collabora.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox