From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: xuanzhenggang001@208suo.com
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned'
Date: Tue, 25 Jul 2023 10:45:49 +0200 [thread overview]
Message-ID: <ZL+LvWjuWWJPXTIG@alpha.franken.de> (raw)
In-Reply-To: <e30eb541f2fc615b264a70af2f40a5f9@208suo.com>
On Sun, Jul 09, 2023 at 10:19:50PM +0800, xuanzhenggang001@208suo.com wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
> arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use
> of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>
> ---
> arch/mips/kernel/linux32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c
> index 6b61be486303..4bd52b38dd00 100644
> --- a/arch/mips/kernel/linux32.c
> +++ b/arch/mips/kernel/linux32.c
> @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad,
> flags);
> }
>
> -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2,
> - unsigned offset_a3, unsigned len_a4, unsigned len_a5)
> +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2,
> + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5)
> {
> return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3),
> merge_64(len_a4, len_a5));
this is white-space damaged, please resend with that corrected.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-07-25 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230709141701.16324-1-denghuilong@cdjrlc.com>
2023-07-09 14:19 ` [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' xuanzhenggang001
2023-07-11 11:53 ` Philippe Mathieu-Daudé
2023-07-25 8:45 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL+LvWjuWWJPXTIG@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=xuanzhenggang001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox