From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0944BC04E69 for ; Tue, 25 Jul 2023 09:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbjGYJAB (ORCPT ); Tue, 25 Jul 2023 05:00:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbjGYI76 (ORCPT ); Tue, 25 Jul 2023 04:59:58 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2A8DE121; Tue, 25 Jul 2023 01:59:53 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qODtR-0008Gp-00; Tue, 25 Jul 2023 10:59:45 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 78FCEC01D0; Tue, 25 Jul 2023 10:45:49 +0200 (CEST) Date: Tue, 25 Jul 2023 10:45:49 +0200 From: Thomas Bogendoerfer To: xuanzhenggang001@208suo.com Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' Message-ID: References: <20230709141701.16324-1-denghuilong@cdjrlc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 09, 2023 at 10:19:50PM +0800, xuanzhenggang001@208suo.com wrote: > Fix the following warnings reported by checkpatch: > > arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > > Signed-off-by: Zhenggang Xuan > --- > arch/mips/kernel/linux32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c > index 6b61be486303..4bd52b38dd00 100644 > --- a/arch/mips/kernel/linux32.c > +++ b/arch/mips/kernel/linux32.c > @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad, > flags); > } > > -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2, > - unsigned offset_a3, unsigned len_a4, unsigned len_a5) > +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2, > + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5) > { > return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3), > merge_64(len_a4, len_a5)); this is white-space damaged, please resend with that corrected. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]