From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rob Herring <robh@kernel.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
John Crispin <john@phrozen.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Explicitly include correct DT includes
Date: Tue, 25 Jul 2023 10:48:40 +0200 [thread overview]
Message-ID: <ZL+MaK820fzdfw+5@alpha.franken.de> (raw)
In-Reply-To: <20230714174028.4040093-1-robh@kernel.org>
On Fri, Jul 14, 2023 at 11:40:27AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/mips/bmips/setup.c | 1 -
> arch/mips/cavium-octeon/flash_setup.c | 3 ++-
> arch/mips/lantiq/irq.c | 2 +-
> arch/mips/lantiq/xway/dcdc.c | 3 ++-
> arch/mips/lantiq/xway/gptu.c | 4 ++--
> arch/mips/lantiq/xway/sysctrl.c | 1 -
> arch/mips/lantiq/xway/vmmc.c | 3 ++-
> arch/mips/pci/pci-lantiq.c | 4 ++--
> arch/mips/pci/pci-rt2880.c | 5 ++---
> arch/mips/pic32/pic32mzda/config.c | 1 -
> arch/mips/ralink/irq.c | 2 +-
> arch/mips/ralink/of.c | 2 +-
> arch/mips/ralink/prom.c | 2 --
> 13 files changed, 15 insertions(+), 18 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-07-25 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:40 [PATCH] MIPS: Explicitly include correct DT includes Rob Herring
2023-07-25 8:48 ` Thomas Bogendoerfer [this message]
2023-07-26 18:15 ` Geert Uytterhoeven
2023-07-26 20:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL+MaK820fzdfw+5@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox