From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E23FC0015E for ; Mon, 24 Jul 2023 14:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbjGXOcg (ORCPT ); Mon, 24 Jul 2023 10:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbjGXOca (ORCPT ); Mon, 24 Jul 2023 10:32:30 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A723210D9 for ; Mon, 24 Jul 2023 07:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690209145; x=1721745145; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2/7McPeueNkR5CKjfh+1JkwAc43EdhYfRO57egeVcAM=; b=XuOP+pG5Rzl+0YYLLc9HTN4L56PYZhXzzt+Jla2HNCkiZtt8PV7okOPo +Ztyltjlb8orF50o7KOp+Z2rZzV391h8AEMSyqttwqnug7DikjvOcAm93 mJUb4PO6RsUGfaGFltxDl+PpHRyeZajpVGAsQmWPx49K+jB4oQ/ZrpIvR lse+ttPqln6UFIfbhIOk3ZmLKqCNFcD1CQaVaDIdXiapM8xoFVmkxtPnI w5DmqFUCz+hjv3YmUQrOTdkK7EY0OEsmWfewUN+LIlCVUlmHoWMICwgin 0Cuq8xLvqovUxQ+u3DwEHnDONlDHffCVtbFSk4jPdhbxibgeoSKP7vG4Y Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="398363210" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="398363210" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 07:32:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="790986953" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="790986953" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 24 Jul 2023 07:32:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qNwbS-00H4oV-2M; Mon, 24 Jul 2023 17:32:02 +0300 Date: Mon, 24 Jul 2023 17:32:02 +0300 From: Andy Shevchenko To: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , Rasmus Villemoes , Andrew Morton , Herve Codina , "Jason A. Donenfeld" , Yang Guang Subject: Re: [PATCH v1 1/1] Revert "um: Use swap() to make code cleaner" Message-ID: References: <20230724142307.28411-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724142307.28411-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 05:23:07PM +0300, Andy Shevchenko wrote: > This reverts commit 9b0da3f22307af693be80f5d3a89dc4c7f360a85. > > The sigio.h is clearly user space code which is handled by Should be .c > arch/um/scripts/Makefile.rules (see USER_OBJS rule). > > The above mentioned commit simply broke this agreement, > we may not use Linux kernel internal headers in them without > thorough thinking. > > Hence, revert the wrong commit. Missing Reported-by > Closes: https://lore.kernel.org/oe-kbuild-all/202307212304.cH79zJp1-lkp@intel.com/ I have just sent a v2: https://lore.kernel.org/r/20230724143131.30090-1-andriy.shevchenko@linux.intel.com. -- With Best Regards, Andy Shevchenko