From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5640EB64DD for ; Mon, 24 Jul 2023 21:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjGXVJM (ORCPT ); Mon, 24 Jul 2023 17:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjGXVJK (ORCPT ); Mon, 24 Jul 2023 17:09:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE04E1BC for ; Mon, 24 Jul 2023 14:09:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8743961263 for ; Mon, 24 Jul 2023 21:09:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 898A0C433C8; Mon, 24 Jul 2023 21:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690232947; bh=AxIobRBY2/FxVQu3cP3nLe9fjgkFu7v5YoBCsJlOszA=; h=Date:From:To:Cc:Subject:From; b=lB3gRgm7k6xhfX0uIm09ccs+nQ1AtwJpE5kTUsJ6XdDBhD/h5y+Ij/aSdKb3Ca98Z HUa1JfJj3JRmG92ARdqtfiyAe4sXl38KfcmaGmgEono4jbUCxnbqidG3Z7JiMD5JN8 QbsVOmHlgY/ZR8QjWpl0evV0A8Z+tVdZMUrdI5ixD7t/pF/KZePdrF3LtOTX+8EN0W qtdvyEaRgS4JPpTxx1HagP4g53+RguYhwfkl+3xgCzCsA4sVnTL1xJYghg5+uvHbeK 8tplp6dqxc/1LbLCGg4CvnwdFZQcmspG/BUjRbZ7yDwwOUt/1L+BWLn+lv6fxKwGpb kG04dLc142h3w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B203140516; Mon, 24 Jul 2023 18:09:04 -0300 (-03) Date: Mon, 24 Jul 2023 18:09:04 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: "Aneesh Kumar K.V" , Athira Rajeev , Disha Goel , Ian Rogers , Jiri Olsa , Kajol Jain , Madhavan Srinivasan , Namhyung Kim , Linux Kernel Mailing List Subject: [PATCH 1/1] perf dlfilter: Initialize addr_location before passing it to thread__find_symbol_fb() Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As thread__find_symbol_fb() will end up calling thread__find_map() and it in turn will call these on uninitialized memory: maps__zput(al->maps); map__zput(al->map); thread__zput(al->thread); Fixes: 0dd5041c9a0eaf8c ("perf addr_location: Add init/exit/copy functions") Cc: Adrian Hunter Cc: Aneesh Kumar K.V Cc: Athira Rajeev Cc: Disha Goel Cc: Ian Rogers Cc: Jiri Olsa Cc: Kajol Jain Cc: Madhavan Srinivasan Cc: Namhyung Kim Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/dlfilter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/dlfilter.c b/tools/perf/util/dlfilter.c index 46f74b2344dbb34c..798a53d7e6c9dfc5 100644 --- a/tools/perf/util/dlfilter.c +++ b/tools/perf/util/dlfilter.c @@ -166,6 +166,7 @@ static __s32 dlfilter__resolve_address(void *ctx, __u64 address, struct perf_dlf if (!thread) return -1; + addr_location__init(&al); thread__find_symbol_fb(thread, d->sample->cpumode, address, &al); al_to_d_al(&al, &d_al); -- 2.37.1