From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: hdegoede@redhat.com, markgross@kernel.org,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] platform/x86/intel/tpmi: Add debugfs interface
Date: Thu, 13 Jul 2023 19:42:14 +0300 [thread overview]
Message-ID: <ZLApZqPhOpKGNyxI@smile.fi.intel.com> (raw)
In-Reply-To: <befd890f0252f0cec193d3bea379c2e23e62e824.camel@linux.intel.com>
On Wed, Jul 12, 2023 at 04:06:50PM -0700, srinivas pandruvada wrote:
> On Wed, 2023-07-12 at 18:13 +0300, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 03:09:48PM -0700, Srinivas Pandruvada wrote:
...
> > > struct intel_tpmi_pm_feature {
> > > struct intel_tpmi_pfs_entry pfs_header;
> > > unsigned int vsec_offset;
> > > + struct intel_vsec_device *vsec_dev;
> >
> > Hmm... I don't know the layout of pfs_header, but this may be 4 bytes
> > less
> > if you move it upper.
> The pfs_header is packed with size of 64 bit. So size will not change.
So, it will be a gap of 4 bytes due to alignment, no?
> > > };
...
> > > + for (i = 0; i < tpmi_info->feature_count; ++i) {
> >
> > Why preincrement?
> Does it matter for a "for" loop increment?
Stylewise. Preincrement raises a flag to the reader "what the heck is special
here that we need preincrement". If not required, I would use postincrement.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-13 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 22:09 [PATCH v2 0/3] TPMI control and debugfs support Srinivas Pandruvada
2023-07-11 22:09 ` [PATCH v2 1/3] platform/x86/intel/tpmi: Read feature control status Srinivas Pandruvada
2023-07-12 15:05 ` Andy Shevchenko
2023-07-12 23:03 ` srinivas pandruvada
2023-07-11 22:09 ` [PATCH v2 2/3] platform/x86/intel/tpmi: Add debugfs interface Srinivas Pandruvada
2023-07-12 15:13 ` Andy Shevchenko
2023-07-12 23:06 ` srinivas pandruvada
2023-07-13 16:42 ` Andy Shevchenko [this message]
2023-07-11 22:09 ` [PATCH v2 3/3] doc: TPMI: Add debugfs documentation Srinivas Pandruvada
2023-07-12 15:14 ` Andy Shevchenko
2023-07-12 23:07 ` srinivas pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLApZqPhOpKGNyxI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox