From: Thierry Reding <thierry.reding@gmail.com>
To: 杜敏杰 <duminjie@vivo.com>
Cc: Baolu Lu <baolu.lu@linux.intel.com>,
Krishna Reddy <vdumpa@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
"open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>,
"opensource.kernel" <opensource.kernel@vivo.com>,
Thierry Reding <treding@nvidia.com>
Subject: Re: 回复: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
Date: Fri, 14 Jul 2023 10:41:03 +0200 [thread overview]
Message-ID: <ZLEKH8ixyRH7IzLK@orome> (raw)
In-Reply-To: <SG2PR06MB5288ED578DB3CE7DA2B25AB5AE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
On Fri, Jul 14, 2023 at 03:21:47AM +0000, 杜敏杰 wrote:
> Hi Baolu!
>
> It seems that 'smmu->debugfs' check is still needed.
> Then I will modify the patch.
> Thanks!
>
> regards,
> Minjie
Don't top-post, please. See Documentation/process/2.Process.rst and
Documentation/process/submitting-patches.rst.
Also, how did you come to the above conclusion? Baolu said that Greg
keeps reminding people that we shouldn't do error handling for debugfs
and gave a Reviewed-by:, so why the 180?
Thierry
> -----邮件原件-----
> 发件人: Baolu Lu <baolu.lu@linux.intel.com>
> 发送时间: 2023年7月14日 10:58
> 收件人: 杜敏杰 <duminjie@vivo.com>; Thierry Reding <thierry.reding@gmail.com>; Krishna Reddy <vdumpa@nvidia.com>; Joerg Roedel <joro@8bytes.org>; Will Deacon <will@kernel.org>; Robin Murphy <robin.murphy@arm.com>; Jonathan Hunter <jonathanh@nvidia.com>; open list:TEGRA IOMMU DRIVERS <linux-tegra@vger.kernel.org>; open list:IOMMU SUBSYSTEM <iommu@lists.linux.dev>; open list <linux-kernel@vger.kernel.org>
> 抄送: baolu.lu@linux.intel.com; opensource.kernel <opensource.kernel@vivo.com>; Thierry Reding <treding@nvidia.com>
> 主题: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
>
> [Some people who received this message don't often get email from baolu.lu@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On 2023/7/13 15:28, Minjie Du wrote:
> > debugfs_create_file() will return early if smmu->debugfs is an error
> > pointer, so an extra error check is not needed.
> >
> > Signed-off-by: Minjie Du<duminjie@vivo.com>
> > Acked-by: Thierry Reding<treding@nvidia.com>
>
> Greg keeps reminding that no error branch for debugfs, so
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>
> Best regards,
> baolu
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-14 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 7:28 [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() Minjie Du
2023-07-14 2:31 ` Baolu Lu
[not found] ` <SG2PR06MB5288E9FC9B6EA21E20BB011EAE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
2023-07-14 2:50 ` 回复: " Baolu Lu
2023-07-14 2:57 ` Baolu Lu
[not found] ` <SG2PR06MB5288ED578DB3CE7DA2B25AB5AE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
2023-07-14 8:41 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEKH8ixyRH7IzLK@orome \
--to=thierry.reding@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=duminjie@vivo.com \
--cc=iommu@lists.linux.dev \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=robin.murphy@arm.com \
--cc=treding@nvidia.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox