From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 15/15] ASoC: Intel: sst: Convert to PCI device IDs defines
Date: Fri, 14 Jul 2023 14:26:45 +0300 [thread overview]
Message-ID: <ZLEw9S8hmkcdk7K2@smile.fi.intel.com> (raw)
In-Reply-To: <20230714185615.370597-16-amadeuszx.slawinski@linux.intel.com>
On Fri, Jul 14, 2023 at 08:56:15PM +0200, Amadeusz Sławiński wrote:
> Use PCI device IDs from pci_ids.h header.
Perhaps one more sentence to explain why this is okay change, like:
"The ACPI IDs are used only internally and lower 16 bits uniquely define
the device as vendor ID for Intel is 8086 for all of them."
Suggested-by: ?
...
> - { PCI_VDEVICE(INTEL, SST_MRFLD_PCI_ID), 0},
> + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SST_TNG), 0},
That 0 is not needed, OTOH you may use PCI_DEVICE_DATA(..., 0).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-14 11:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 18:56 [PATCH v2 00/15] PCI: Define Intel PCI IDs and use them in drivers Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 01/15] PCI: Sort Intel PCI IDs by number Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 02/15] PCI: Add Intel Audio DSP devices to pci_ids.h Amadeusz Sławiński
2023-07-14 11:16 ` Andy Shevchenko
2023-07-14 18:56 ` [PATCH v2 03/15] ASoC: SOF: Remove unused Broxton PCI ID Amadeusz Sławiński
2023-07-14 11:17 ` Andy Shevchenko
2023-07-14 18:56 ` [PATCH v2 04/15] ALSA: " Amadeusz Sławiński
2023-07-14 11:18 ` Andy Shevchenko
2023-07-14 18:56 ` [PATCH v2 05/15] ALSA: hda: Add controller matching macros Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 06/15] ALSA: hda: Use global PCI match macro Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 07/15] ALSA: hda/i915: " Amadeusz Sławiński
2023-07-14 11:20 ` Andy Shevchenko
2023-07-14 11:23 ` Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 08/15] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 09/15] ALSA: intel-dsp-config: Convert to PCI device IDs defines Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 10/15] ALSA: hda: " Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 11/15] ASoC: Intel: avs: " Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 12/15] " Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 13/15] ASoC: Intel: Skylake: " Amadeusz Sławiński
2023-07-14 18:56 ` [PATCH v2 14/15] ASoC: SOF: Intel: " Amadeusz Sławiński
2023-07-14 11:23 ` Andy Shevchenko
2023-07-14 18:56 ` [PATCH v2 15/15] ASoC: Intel: sst: " Amadeusz Sławiński
2023-07-14 11:26 ` Andy Shevchenko [this message]
2023-07-14 11:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEw9S8hmkcdk7K2@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox