From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA83C0015E for ; Fri, 14 Jul 2023 11:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234965AbjGNL0x (ORCPT ); Fri, 14 Jul 2023 07:26:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232120AbjGNL0v (ORCPT ); Fri, 14 Jul 2023 07:26:51 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC6142D63; Fri, 14 Jul 2023 04:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689334010; x=1720870010; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ybJ/zTQMZflW+QDzy7QdMvE5i6zccg/T78xnlv907o0=; b=Tz8jmLiFkgCUiVRkWXIdok+rlWc70egE9X/SggB9ExF2XM3HukAK8zSL yMKT8CegH+ZuxPlixrV9lIc4DuOgDvkhODC29C8e661MsSLkqgJB9FvgH j35srHtXxoue04omrhQ7XEM9aU2FXjFdP7RHrRD2YUkaILfAQpNbQAHXy 7amtkSy6ouP3UoVbC0ps4+yP0Erq6fqkXyS8Yta78TpQ+X3t/h97YY3Yt ubXsp/5aY5D7Qtn0Fiex2kpyICcyLS43svm9ZDK+A69raf7UF6DKs6mea ZxM/Or67PuY8abKSWrLFdLmPeNnoRu2czdWs9uYB1n4qep8MpGDyJtAc+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="365489655" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="365489655" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2023 04:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="812392903" X-IronPort-AV: E=Sophos;i="6.01,205,1684825200"; d="scan'208";a="812392903" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 14 Jul 2023 04:26:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qKGwf-002e2d-2K; Fri, 14 Jul 2023 14:26:45 +0300 Date: Fri, 14 Jul 2023 14:26:45 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen , Hans de Goede Subject: Re: [PATCH v2 15/15] ASoC: Intel: sst: Convert to PCI device IDs defines Message-ID: References: <20230714185615.370597-1-amadeuszx.slawinski@linux.intel.com> <20230714185615.370597-16-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230714185615.370597-16-amadeuszx.slawinski@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 08:56:15PM +0200, Amadeusz Sławiński wrote: > Use PCI device IDs from pci_ids.h header. Perhaps one more sentence to explain why this is okay change, like: "The ACPI IDs are used only internally and lower 16 bits uniquely define the device as vendor ID for Intel is 8086 for all of them." Suggested-by: ? ... > - { PCI_VDEVICE(INTEL, SST_MRFLD_PCI_ID), 0}, > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SST_TNG), 0}, That 0 is not needed, OTOH you may use PCI_DEVICE_DATA(..., 0). -- With Best Regards, Andy Shevchenko