[PATCH] tools/nolibc: Fix warnings in ctype.h

[PATCH] tools/nolibc: Fix warnings in ctype.h

[shijie001]

The following checkpatch warnings are removed:
WARNING: __always_unused or __maybe_unused is preferred over 
__attribute__((__unused__))

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  tools/include/nolibc/ctype.h | 26 +++++++++++++-------------
  1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/tools/include/nolibc/ctype.h b/tools/include/nolibc/ctype.h
index 6f90706d0644..41c49002c0fc 100644
--- a/tools/include/nolibc/ctype.h
+++ b/tools/include/nolibc/ctype.h
@@ -13,84 +13,84 @@
   * As much as possible, please keep functions alphabetically sorted.
   */

-static __attribute__((unused))
+static __always_unused
  int isascii(int c)
  {
      /* 0x00..0x7f */
      return (unsigned int)c <= 0x7f;
  }

-static __attribute__((unused))
+static __always_unused
  int isblank(int c)
  {
      return c == '\t' || c == ' ';
  }

-static __attribute__((unused))
+static __always_unused
  int iscntrl(int c)
  {
      /* 0x00..0x1f, 0x7f */
      return (unsigned int)c < 0x20 || c == 0x7f;
  }

-static __attribute__((unused))
+static __always_unused
  int isdigit(int c)
  {
      return (unsigned int)(c - '0') < 10;
  }

-static __attribute__((unused))
+static __always_unused
  int isgraph(int c)
  {
      /* 0x21..0x7e */
      return (unsigned int)(c - 0x21) < 0x5e;
  }

-static __attribute__((unused))
+static __always_unused
  int islower(int c)
  {
      return (unsigned int)(c - 'a') < 26;
  }

-static __attribute__((unused))
+static __always_unused
  int isprint(int c)
  {
      /* 0x20..0x7e */
      return (unsigned int)(c - 0x20) < 0x5f;
  }

-static __attribute__((unused))
+static __always_unused
  int isspace(int c)
  {
      /* \t is 0x9, \n is 0xA, \v is 0xB, \f is 0xC, \r is 0xD */
      return ((unsigned int)c == ' ') || (unsigned int)(c - 0x09) < 5;
  }

-static __attribute__((unused))
+static __always_unused
  int isupper(int c)
  {
      return (unsigned int)(c - 'A') < 26;
  }

-static __attribute__((unused))
+static __always_unused
  int isxdigit(int c)
  {
      return isdigit(c) || (unsigned int)(c - 'A') < 6 || (unsigned 
int)(c - 'a') < 6;
  }

-static __attribute__((unused))
+static __always_unused
  int isalpha(int c)
  {
      return islower(c) || isupper(c);
  }

-static __attribute__((unused))
+static __always_unused
  int isalnum(int c)
  {
      return isalpha(c) || isdigit(c);
  }

-static __attribute__((unused))
+static __always_unused
  int ispunct(int c)
  {
      return isgraph(c) && !isalnum(c);

Re: [PATCH] tools/nolibc: Fix warnings in ctype.h

[Willy Tarreau]

Hello,

On Mon, Jul 17, 2023 at 03:18:50PM +0800, shijie001@208suo.com wrote:
> The following checkpatch warnings are removed:
> WARNING: __always_unused or __maybe_unused is preferred over
> __attribute__((__unused__))

Thanks but that's userland code, which doesn't have access to the kernel
macros, hence this usage.

Regards,
willy