From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Mark Gross <markgross@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Armin Wolf <W_Armin@gmx.de>
Subject: Re: [RFC PATCH v1] platform/x86: wmi: Do not register driver with invalid GUID
Date: Mon, 17 Jul 2023 12:49:58 +0300 [thread overview]
Message-ID: <ZLUOxnE58wUgZXWx@smile.fi.intel.com> (raw)
In-Reply-To: <20230715211604.1272227-1-pobrn@protonmail.com>
On Sat, Jul 15, 2023 at 09:24:16PM +0000, Barnabás Pőcze wrote:
> Since a WMI driver's ID table contains strings it is relatively
> easy to make mistakes. At the moment, there is no feedback
> if any of the specified GUIDs are invalid (since
> 028e6e204ace1f080cfeacd72c50397eb8ae8883).
>
> So check if the GUIDs in the driver's ID table are valid,
> print all invalid ones, and refuse to register the driver
> if any of the GUIDs are invalid.
Besides using wrong API (uuid_*() vs. guid_*() one), I don't
think we need to validate it here. Why not in file2alias.c?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-17 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 21:24 [RFC PATCH v1] platform/x86: wmi: Do not register driver with invalid GUID Barnabás Pőcze
2023-07-17 9:49 ` Andy Shevchenko [this message]
2023-07-17 11:23 ` Barnabás Pőcze
2023-07-17 11:31 ` Andy Shevchenko
2023-07-19 19:23 ` Barnabás Pőcze
2023-07-20 8:36 ` Andy Shevchenko
2023-07-20 10:42 ` Barnabás Pőcze
2023-07-21 9:17 ` Andy Shevchenko
2023-07-26 8:45 ` Hans de Goede
2023-07-27 22:54 ` Barnabás Pőcze
2023-07-28 10:02 ` Andy Shevchenko
2023-07-28 14:39 ` Barnabás Pőcze
2023-07-31 19:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLUOxnE58wUgZXWx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox