From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC73C0015E for ; Mon, 17 Jul 2023 16:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231960AbjGQQJN (ORCPT ); Mon, 17 Jul 2023 12:09:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjGQQJL (ORCPT ); Mon, 17 Jul 2023 12:09:11 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65D91AC for ; Mon, 17 Jul 2023 09:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689610150; x=1721146150; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YY+53Xlu9otT4LWLR5OcoAlxNJ/QtG/+upDrxe/Yolg=; b=P65KOabzOwl4OpdSQaLCVVuqN68gevKGsBi9Wky7i80V6ub4lCWvnoZ2 U9xfN4GBZphQWV3s23it90+V+aLhONwsIEBaPLkijR93eAg5MmnMBBfT6 ktV/aNyNT3J0wYQL2UeLXbqaThfx9tMlEw52Fi9RTJvCjdze7sabx8FJM LAnfCV5mSmygzYp424bnhwGzHE/9b61mcRh2HxDlPPnwYTr+rZH4Z2N41 Avb1oZ8b2WhL6P0ik3yQXEHNUjRDjqJaPUodiDhexU4DgdhM8tZ1KVfTR u3i+hRxA9zJYwvxEcwRhZYWQLlmYrZr6R24rM5AKVbP81gdJH7s09Q6TR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="432142360" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="432142360" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 09:05:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="847351900" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="847351900" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2023 09:05:46 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLQjI-004Gx5-2x; Mon, 17 Jul 2023 19:05:44 +0300 Date: Mon, 17 Jul 2023 19:05:44 +0300 From: Andy Shevchenko To: Kees Cook Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy() Message-ID: References: <20230717093332.54236-1-andriy.shevchenko@linux.intel.com> <202307170826.397635AD@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202307170826.397635AD@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote: > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote: ... > I think this doesn't need to use seq_show_option_n() at all. Quite likely. Nevertheless, it's one of the dozens (?) warnings like this. ... > Reviewed-by: Kees Cook Thank you for the review! I think it's you who may take it as seq_file.h seems everybody's playground. -- With Best Regards, Andy Shevchenko