Re: [PATCH 3/3] fs/9p: fix type mismatch in file cache mode helper

Dominique Martinet
2023-07-18T02:50:34Z

Eric Van Hensbergen wrote on Mon, Jul 17, 2023 at 04:29:02PM +0000:
> There were two flags which had incorrect type in the
> paramaters of the file cache mode helper function.

Checked the parameters passed (v9ses->cache, file->f_flags and a flags
parent function parameters) were all correctly unsigned:

Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>

>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
> ---
> fs/9p/fid.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/fid.h b/fs/9p/fid.h
> index 297c2c377e3dd..29281b7c38870 100644
> --- a/fs/9p/fid.h
> +++ b/fs/9p/fid.h
> @@ -46,8 +46,8 @@ static inline struct p9_fid *v9fs_fid_clone(struct dentry *dentry)
> * NOTE: these are set after open so only reflect 9p client not
> * underlying file system on server.
> */
> -static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
> - int s_cache, unsigned int f_flags)
> +static inline void v9fs_fid_add_modes(struct p9_fid *fid, unsigned int s_flags,
> + unsigned int s_cache, unsigned int f_flags)
> {
> if (fid->qid.type != P9_QTFILE)
> return;
>

--
Dominique Martinet | Asmadeus