Re: [PATCH 2/3] fs/9p: fix typo in comparison logic for cache mode

Dominique Martinet
2023-07-18T02:49:18Z

Eric Van Hensbergen wrote on Mon, Jul 17, 2023 at 04:29:01PM +0000:
> There appears to be a typo in the comparison statement for the logic
> which sets a file's cache mode based on mount flags.

Shouldn't break anything, but good fix nevertheless, thanks!

Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>

>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
> ---
> fs/9p/fid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/9p/fid.h b/fs/9p/fid.h
> index 0c51889a60b33..297c2c377e3dd 100644
> --- a/fs/9p/fid.h
> +++ b/fs/9p/fid.h
> @@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
> (s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) {
> fid->mode |= P9L_DIRECT; /* no read or write cache */
> } else if ((!(s_cache & CACHE_WRITEBACK)) ||
> - (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) {
> + (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) {
> fid->mode |= P9L_NOWRITECACHE;
> }
> }
>

--
Dominique Martinet | Asmadeus