From: Dominique Martinet <asmadeus@codewreck.org>
To: Eric Van Hensbergen <ericvh@kernel.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
Robert Schwebel <r.schwebel@pengutronix.de>
Subject: Re: [PATCH 2/3] fs/9p: fix typo in comparison logic for cache mode
Date: Tue, 18 Jul 2023 11:48:53 +0900 [thread overview]
Message-ID: <ZLX9lUnIwLYT-Oc4@codewreck.org> (raw)
In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v1-2-0683b283b932@kernel.org>
Eric Van Hensbergen wrote on Mon, Jul 17, 2023 at 04:29:01PM +0000:
> There appears to be a typo in the comparison statement for the logic
> which sets a file's cache mode based on mount flags.
Shouldn't break anything, but good fix nevertheless, thanks!
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
> ---
> fs/9p/fid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/9p/fid.h b/fs/9p/fid.h
> index 0c51889a60b33..297c2c377e3dd 100644
> --- a/fs/9p/fid.h
> +++ b/fs/9p/fid.h
> @@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
> (s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) {
> fid->mode |= P9L_DIRECT; /* no read or write cache */
> } else if ((!(s_cache & CACHE_WRITEBACK)) ||
> - (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) {
> + (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) {
> fid->mode |= P9L_NOWRITECACHE;
> }
> }
>
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2023-07-18 2:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:28 [PATCH 0/3] fs/9p: fix mmap regression Eric Van Hensbergen
2023-07-17 16:29 ` [PATCH 1/3] fs/9p: remove unecessary and overrestrictive check Eric Van Hensbergen
2023-07-18 2:45 ` Dominique Martinet
2023-07-18 9:17 ` Christian Schoenebeck
2023-07-17 16:29 ` [PATCH 2/3] fs/9p: fix typo in comparison logic for cache mode Eric Van Hensbergen
2023-07-18 2:48 ` Dominique Martinet [this message]
2023-07-18 9:34 ` Christian Schoenebeck
2023-07-17 16:29 ` [PATCH 3/3] fs/9p: fix type mismatch in file cache mode helper Eric Van Hensbergen
2023-07-18 2:50 ` Dominique Martinet
2023-07-18 9:40 ` Christian Schoenebeck
2023-07-19 14:17 ` [PATCH 0/3] fs/9p: fix mmap regression Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLX9lUnIwLYT-Oc4@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=r.schwebel@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox