RE: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors

Fabrizio Castro
2023-07-18T15:07:46Z

Hi Randy,

> From: Randy Dunlap <rd.dunlab@gmail.com>
> Subject: Re: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
>
> On 7/18/23 05:13, Fabrizio Castro wrote:
> > Hi Randy,
> >
> >> From: Randy Dunlap <rd.dunlab@gmail.com>
> >> Subject: [PATCH v2] pwm: fix pwm-rz-mtu3.c build errors
> >>
> >> From: Randy Dunlap <rd.dunlab@gmail.com>
> >>
> >> When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build
> >> errors:
> >>
> >>
> >> Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is
> >> still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being
> built
> >> but also allow the latter not to be built.
> >>
> >> drivers/pwm/Kconfig | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> >> --- a/drivers/pwm/Kconfig
> >> +++ b/drivers/pwm/Kconfig
> >> @@ -505,7 +505,8 @@ config PWM_ROCKCHIP
> >>
> >> config PWM_RZ_MTU3
> >> tristate "Renesas RZ/G2L MTU3a PWM Timer support"
> >> - depends on RZ_MTU3 || COMPILE_TEST
> >> + depends on COMPILE_TEST
> >> + depends on RZ_MTU3 || RZ_MTU3=n
> >
> > Isn't this a tautology?
>
> Not at all. It's used in Kconfig quite a bit.
> This is tristate logic.
>
> It says that if RZ_MTU3 is y/m, PWM_RZ_MTU3 is limited by that.
> But if RZ_MTU3 is n, PWM_RZ_MTU3 can be y or m.
>
> Is that clearer?

It is, thanks for the explanation!

Cheers,
Fab

>
> --
> ~Randy