From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6590EB64DA for ; Tue, 18 Jul 2023 07:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbjGRHse (ORCPT ); Tue, 18 Jul 2023 03:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjGRHsc (ORCPT ); Tue, 18 Jul 2023 03:48:32 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AD52C2; Tue, 18 Jul 2023 00:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j+i21QBw8qfDQnATHCmmVuENnVwo331oWLbf8352h5c=; b=BCUxAH8MsuZLkZB46+VAsSKme+ +dlcrVF6Ux4icCGwqrHrSIOnxPh2aUVcGsjfE2kD8gqRq/qextc4M9qq5Y8s6MQkKO2MD9m5mnoZ0 8pOTNIbVO+FGKVU7WWhQ7711Vs+iWEyosVJUtgHxti24FwQYtreZMKi+RPm1O7DBuBlb7WuiTDvi4 x4NqtY/nhENC19iP3UWSmLI240tnm+kK1/H6IVw6MdL4ETdJqyz3Y2QOLgDOAcFVXbruJKvJNRJt0 EoSkr4ms061LTYvEomoM5CHpJKGjZrhaBDvVtSdi4fV/KtAyEvZ/goEMY6P/CwED0+Xqj/LEwltn1 nwfvDkMw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48300) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qLfRe-0005Xl-0H; Tue, 18 Jul 2023 08:48:30 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qLfRd-0002rs-TG; Tue, 18 Jul 2023 08:48:29 +0100 Date: Tue, 18 Jul 2023 08:48:29 +0100 From: "Russell King (Oracle)" To: "M. Haener" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Sverdlin Subject: Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops Message-ID: References: <20230718065937.10713-1-michael.haener@siemens.com> <20230718065937.10713-4-michael.haener@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 08:47:23AM +0100, Russell King (Oracle) wrote: > On Tue, Jul 18, 2023 at 08:59:31AM +0200, M. Haener wrote: > > From: Michael Haener > > > > The 88e632x family has several SERDES 100/1000 blocks. By adding these > > operations, these functionalities can be used. > > > > Signed-off-by: Michael Haener > > --- > > Changelog: > > v3: rebased onto main branch > > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink > > I think you're missing something - you seem to be adding support to read > the statistics from these blocks, but you're not actually driving them > at all in terms of reading their status or configuring them. > > You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that. ... and this is why you need to be able to test on recent kernels! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!