From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C0DC001DC for ; Tue, 18 Jul 2023 19:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229568AbjGRTik (ORCPT ); Tue, 18 Jul 2023 15:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjGRTij (ORCPT ); Tue, 18 Jul 2023 15:38:39 -0400 Received: from smtp.dudau.co.uk (dliviu.plus.com [80.229.23.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E8C87198D; Tue, 18 Jul 2023 12:38:37 -0700 (PDT) Received: from mail.dudau.co.uk (bart.dudau.co.uk [192.168.14.2]) by smtp.dudau.co.uk (Postfix) with SMTP id 1735441A7003; Tue, 18 Jul 2023 20:38:36 +0100 (BST) Received: by mail.dudau.co.uk (sSMTP sendmail emulation); Tue, 18 Jul 2023 20:38:36 +0100 Date: Tue, 18 Jul 2023 20:38:36 +0100 From: Liviu Dudau To: Sebastian Reichel Cc: linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , Vinod Koul , Kishon Vijay Abraham I , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Serge Semin , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Shawn Lin , Simon Xue , John Clark , Qu Wenruo , devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: rk3588: add PCIe3 support Message-ID: References: <20230717173512.65169-1-sebastian.reichel@collabora.com> <20230717173512.65169-3-sebastian.reichel@collabora.com> <20230718160137.sfitnkl6gmyi75jx@mercury.elektranox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230718160137.sfitnkl6gmyi75jx@mercury.elektranox.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 06:01:37PM +0200, Sebastian Reichel wrote: > Hi Liviu, > > On Tue, Jul 18, 2023 at 04:09:53PM +0100, Liviu Dudau wrote: > > On Mon, Jul 17, 2023 at 07:35:12PM +0200, Sebastian Reichel wrote: > > > Add both PCIe3 controllers together with the shared PHY. > > > > > > Signed-off-by: Sebastian Reichel > > > --- > > > arch/arm64/boot/dts/rockchip/rk3588.dtsi | 120 +++++++++++++++++++++++ > > > 1 file changed, 120 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi > > > index 88d702575db2..8f210f002fac 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3588.dtsi > > > +++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi > > > @@ -7,6 +7,11 @@ > > > #include "rk3588-pinctrl.dtsi" > > > > > > / { > > > + pcie30_phy_grf: syscon@fd5b8000 { > > > + compatible = "rockchip,rk3588-pcie3-phy-grf", "syscon"; > > > + reg = <0x0 0xfd5b8000 0x0 0x10000>; > > > + }; > > > + > > > pipe_phy1_grf: syscon@fd5c0000 { > > > compatible = "rockchip,rk3588-pipe-phy-grf", "syscon"; > > > reg = <0x0 0xfd5c0000 0x0 0x100>; > > > > What tree is based this on? Even after applying your PCIe2 series I don't have the above > > node so the patch doesn't apply to mainline. > > You are missing naneng-combphy support: > > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v6.6-armsoc/dts64&id=6ebd55b3bba383e0523b0c014f17c97f3ce80708 Thanks! It looks like the PCIe2 commit that adds support to rk3588(s).dtsi files is also missing an #include for the PHY_TYPE_PCIE use, otherwise the DTS fail to compile. Best regards, Liviu > > -- Sebastian -- Everyone who uses computers frequently has had, from time to time, a mad desire to attack the precocious abacus with an axe. -- John D. Clark, Ignition!