From: Andy Shevchenko <andy@kernel.org>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
brgl@bgdev.pl, linus.walleij@linaro.org,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call
Date: Wed, 19 Jul 2023 18:30:43 +0300 [thread overview]
Message-ID: <ZLgBozzucZdLwLc+@smile.fi.intel.com> (raw)
In-Reply-To: <20230719094803.17677-1-aboutphysycs@gmail.com>
On Wed, Jul 19, 2023 at 12:48:03PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() isn't needed for anything. The function is a
> simple setter that doesn't change anything in the code. That is because
> there isn't a get function and since it has no dependencies it can be
> removed.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-19 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 9:48 [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-19 15:30 ` Andy Shevchenko [this message]
2023-07-29 14:06 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLgBozzucZdLwLc+@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox