From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1349C001B0 for ; Wed, 19 Jul 2023 15:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbjGSPa6 (ORCPT ); Wed, 19 Jul 2023 11:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbjGSPa4 (ORCPT ); Wed, 19 Jul 2023 11:30:56 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBCA9E; Wed, 19 Jul 2023 08:30:55 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="346800912" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="346800912" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 08:30:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="727338892" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="727338892" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2023 08:30:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qM98W-00GGtl-0c; Wed, 19 Jul 2023 18:30:44 +0300 Date: Wed, 19 Jul 2023 18:30:43 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: logicvc: remove unneeded platform_set_drvdata() call Message-ID: References: <20230719094803.17677-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719094803.17677-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2023 at 12:48:03PM +0300, Andrei Coardos wrote: > The platform_set_drvdata() isn't needed for anything. The function is a > simple setter that doesn't change anything in the code. That is because > there isn't a get function and since it has no dependencies it can be > removed. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko