Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]

On Jul 20, Jonathan Cameron wrote:
> Alejandro Tafalla <atafalla@dnyon.com> wrote:
> 
> > On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> > > On Fri, 14 Jul 2023 17:31:26 +0200
> > > 
> > > Alejandro Tafalla <atafalla@dnyon.com> wrote:  
> > > > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > > > ACPI
> > > > support is not enabled to allow executing iio_read_mount_matrix in the
> > > > probe function.
> > > > 
> > > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")  
> > > 
> > > I can fix it up whilst applying if no other issues, but there must not be
> > > a blank line here.  All tags need to be in a single block for some tooling
> > > that is used with the kernel tree (and some of the checking scripts warn
> > > about this so it won't get applied with the blank line here).  
> > 
> > Okay, i'll keep it in mind for new patches. Thank you.
> Np.
> 
> Just waiting for Lorenzo to have time to take a final look.

I am fine with this patch.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> Jonathan
> 
> > >   
> > > > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > > > ---
> > > > Changes in v3:
> > > > - Removed unneeded check for err == -EOPNOTSUPP.
> > > > 
> > > > Changes in v2:
> > > > - Use of error codes instead of true/false
> > > > 
> > > >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > > > 6a18b363cf73..b6e6b1df8a61 100644
> > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > > > device *dev,> 
> > > >  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > > >  
> > > >  					  struct   
> > iio_mount_matrix *orientation)
> > > >  
> > > >  {
> > > > 
> > > > -	return false;
> > > > +	return -EOPNOTSUPP;
> > > > 
> > > >  }
> > > >  
> > > >  #endif  
> > 
> > 
> > 
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]