public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: pangzizhen001@208suo.com, oliver@neukum.org, aliakc@web.de,
	lenehan@twibble.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi: Fix typos in comments
Date: Fri, 21 Jul 2023 11:00:10 +0700	[thread overview]
Message-ID: <ZLoCynrRoXHPn/Dx@debian.me> (raw)
In-Reply-To: <0dbfe7a07c205bde3fc60408ce7aa55a@208suo.com>

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On Fri, Jul 21, 2023 at 12:06:11AM +0800, pangzizhen001@208suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com>
> ---
>  drivers/scsi/dc395x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c8e86f8a631e..077e76407c58 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb,
> struct ScsiReqBlk *srb,
>          /*
>           * KG: We should wait for the DMA FIFO to be empty ...
>           * but: it would be better to wait first for the SCSI FIFO and then
> the
> -         * the DMA FIFO to become empty? How do we know, that the device
> not already
> +         * DMA FIFO to become empty? How do we know, that the device not
> already
>           * sent data to the FIFO in a MsgIn phase, eg.?
>           */
>          if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

I'd like to write the comment above instead as "We should wait for the DMA
FIFO to be empty, but it would be better to wait first for the SCSI one and
then the DMA one to be emptied..."

But hey, you did not read review comments to all your submissions, many
of them (including mine) asking you to not corrupt your patches like this
one did.

Hence NAK from me.

Bye!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2023-07-21  4:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230720160417.4434-1-wangjianli@cdjrlc.com>
2023-07-20 16:06 ` [PATCH] drivers/scsi: Fix typos in comments pangzizhen001
2023-07-21  4:00   ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLoCynrRoXHPn/Dx@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=aliakc@web.de \
    --cc=jejb@linux.ibm.com \
    --cc=lenehan@twibble.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=oliver@neukum.org \
    --cc=pangzizhen001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox