public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/scsi: Fix typos in comments
       [not found] <20230720160417.4434-1-wangjianli@cdjrlc.com>
@ 2023-07-20 16:06 ` pangzizhen001
  2023-07-21  4:00   ` Bagas Sanjaya
  0 siblings, 1 reply; 2+ messages in thread
From: pangzizhen001 @ 2023-07-20 16:06 UTC (permalink / raw)
  To: oliver, aliakc, lenehan, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel

Delete duplicate word "the"

Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com>
---
  drivers/scsi/dc395x.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index c8e86f8a631e..077e76407c58 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk 
*acb, struct ScsiReqBlk *srb,
          /*
           * KG: We should wait for the DMA FIFO to be empty ...
           * but: it would be better to wait first for the SCSI FIFO and 
then the
-         * the DMA FIFO to become empty? How do we know, that the 
device not already
+         * DMA FIFO to become empty? How do we know, that the device 
not already
           * sent data to the FIFO in a MsgIn phase, eg.?
           */
          if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/scsi: Fix typos in comments
  2023-07-20 16:06 ` [PATCH] drivers/scsi: Fix typos in comments pangzizhen001
@ 2023-07-21  4:00   ` Bagas Sanjaya
  0 siblings, 0 replies; 2+ messages in thread
From: Bagas Sanjaya @ 2023-07-21  4:00 UTC (permalink / raw)
  To: pangzizhen001, oliver, aliakc, lenehan, jejb, martin.petersen
  Cc: linux-scsi, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On Fri, Jul 21, 2023 at 12:06:11AM +0800, pangzizhen001@208suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com>
> ---
>  drivers/scsi/dc395x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c8e86f8a631e..077e76407c58 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb,
> struct ScsiReqBlk *srb,
>          /*
>           * KG: We should wait for the DMA FIFO to be empty ...
>           * but: it would be better to wait first for the SCSI FIFO and then
> the
> -         * the DMA FIFO to become empty? How do we know, that the device
> not already
> +         * DMA FIFO to become empty? How do we know, that the device not
> already
>           * sent data to the FIFO in a MsgIn phase, eg.?
>           */
>          if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

I'd like to write the comment above instead as "We should wait for the DMA
FIFO to be empty, but it would be better to wait first for the SCSI one and
then the DMA one to be emptied..."

But hey, you did not read review comments to all your submissions, many
of them (including mine) asking you to not corrupt your patches like this
one did.

Hence NAK from me.

Bye!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-21  4:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230720160417.4434-1-wangjianli@cdjrlc.com>
2023-07-20 16:06 ` [PATCH] drivers/scsi: Fix typos in comments pangzizhen001
2023-07-21  4:00   ` Bagas Sanjaya

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox