From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E822C0015E for ; Fri, 21 Jul 2023 06:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjGUGj6 (ORCPT ); Fri, 21 Jul 2023 02:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjGUGj3 (ORCPT ); Fri, 21 Jul 2023 02:39:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E546330FB for ; Thu, 20 Jul 2023 23:39:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 72A4761407 for ; Fri, 21 Jul 2023 06:39:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52D87C433C8; Fri, 21 Jul 2023 06:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689921548; bh=pPac8yPWmSjpPBsh2tgc9lsmk3v6K1eiIR2YrRDKCmg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pIzdtq4z4rxbfnpL5U/XnFx1v7IJsNaG7Hw8Ha1yG2Lzvs4UdfQ2+p4A7bL/19nW3 vxZMBu7Ql4pxAt1lvhGu7vMu+2qHp6lvqPs5PdLRPu6nRC0h2IwUAa3DaEytV5IcKf R8Bc7RtmqkdGcM4eRNoj9nxyaHPO90kPJ8miKTnBnTw+nhTmYzaGQuIkVQZvezBlCv aF5drmXgGboVEsIfIuCCrexGm9W71CRtg9R1T5zCtjFi929ZjARL+9LAHD921jMpIC RKAiL6hlVVAIse1xoXYG/XC8pEhfLGKS7+BkmyveacjxyZEAjBzlbwgK0txcnR58Ta Y9PT4ef7tTbPg== Date: Fri, 21 Jul 2023 14:39:05 +0800 From: Tzung-Bi Shih To: Alicja Michalska Cc: linux-kernel@vger.kernel.org, robbarnes@google.com, lalithkraj@google.com, rrangel@chromium.org, bleung@chromium.org, groeck@chromium.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Add DMI definition for post-Skylake machines running custom Coreboot builds Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 12:37:15AM +0200, Alicja Michalska wrote: > ChromeOS EC LPC lacks DMI match for newer machines, which > use "Google" DMI_SYS_VENDOR as opposed to "GOOGLE" in older models. I'm confused about the sentence as it looks irrelevant to the patch. > This patch adds DMI definition for MrChomebox's custom Coreboots builds, > which we (Chrultrabook Project) are using. s/This patch adds/Add/. Search "imperative mood" in [1]. Looks like a typo: s/MrChomebox/MrChromebox/. If you get chance to send next version, please shorten the commit title. I guess "platform/chrome: cros_ec_lpc: Add DMI match for MrChromebox" should be quite explicit. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html > + /* DMI doesn't match modern machines running custom firmware */ Remove the line. > + { > + /* MrChromebox's firmware */ > + .matches = { > + DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > + DMI_MATCH(DMI_BIOS_VERSION, "MrChromebox-"), > + }, > + }, Put the block after "A small number of non-Chromebook/box machines also use the ChromeOS EC"[2]. [2]: https://elixir.bootlin.com/linux/v6.4/source/drivers/platform/chrome/cros_ec_lpc.c#L533