From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCEEEB64DD for ; Fri, 21 Jul 2023 10:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbjGUKWr (ORCPT ); Fri, 21 Jul 2023 06:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbjGUKWV (ORCPT ); Fri, 21 Jul 2023 06:22:21 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055941FC8; Fri, 21 Jul 2023 03:22:09 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="364453767" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="364453767" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 03:20:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="718771065" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="718771065" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 21 Jul 2023 03:20:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMnFX-00HMdd-2B; Fri, 21 Jul 2023 13:20:39 +0300 Date: Fri, 21 Jul 2023 13:20:39 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata() Message-ID: References: <20230721094343.25741-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721094343.25741-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 12:43:43PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Wrong version of the patch. Use -v, where is a number. > Reviewed-by: Alexandru Ardelean > Signed-off-by: Andrei Coardos > --- There is no changelog. What has been changed? What's the difference to v1 if this is assumed v2? -- With Best Regards, Andy Shevchenko