From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA061C001DE for ; Fri, 21 Jul 2023 19:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbjGUT3U (ORCPT ); Fri, 21 Jul 2023 15:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbjGUT3R (ORCPT ); Fri, 21 Jul 2023 15:29:17 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97B43189 for ; Fri, 21 Jul 2023 12:29:16 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-666ecf9a081so1997535b3a.2 for ; Fri, 21 Jul 2023 12:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1689967756; x=1690572556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6PVgaqPhmt4wq0AWBCFQwFhvxfFvbSlDYNh4o0Ppojs=; b=GfaxQaKw5x3cV3SfUeA/pzqiy5kUPg0RiENjQHq5dJ46ftZgr6GcEH/8NPMVHUyb15 On/HsOGxBo53R9kz/XnoR9KMjvnJ97KGyHZILWXEZUXDlYAOXodZDrfICC/dFZ/SBWkd 1A9RMfpQiCSehrZEKBRYWCGM6pKRLOddyYpQM6Qny0c2Dyrj6km1I0ScE3lw/3LopZBU mHYA9vyZkoPJGJHI+Ym0bW0XfaN4vFlO0PPvWesldgcLxIRfysJNLp6bSRDAquiwOdvT eYGeNlDw9g03rR9btRmI3899ViEqGdpcH6xzhKko4eGdvLMWmTIAcasv3gC2fW/6G2ma 6EnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689967756; x=1690572556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6PVgaqPhmt4wq0AWBCFQwFhvxfFvbSlDYNh4o0Ppojs=; b=TpDh7VdEHavOBvEz/BtuMkSSQNnTnV+AZIzFlARAcn2bZif0UDczlHf/whkNC36xvV gTtAo+O8HS3gqyT32ZXn3CIHiZQp2f2yMxXABSG4h68tfxzEq0+jxq39rVNVOvsSZkxc 8KV/RHFPvDcPAC3ibCuOKIt49kz5zpuHaICM8Rv6Af6rtqR6CPWSBXes9AfJJpY+c6HS dS/Zxi6JknPQy0eE5zpizwPsbsQR00dm9hbuTFs+7WIEdmShx9wSKUTNv+9/WLibZFKX o+QxOuDU67HMZT/+Eq8kaOKmM6PqKtuWn81iiX3ienBuCOI8TeenS72KGWAhwZD6R6vy /UNw== X-Gm-Message-State: ABy/qLZhWXv+ErA5BPOkJmXZJjP41rHvkWrmVOqAINNGHJY+Dvk3OV25 UkRMrqxSjI6yyXPuVwXOZrxpcg== X-Google-Smtp-Source: APBJJlHhX/ECiPtAgKTdPj/SAH5GJPTRrsthr/G8wSLG2KG1XyYAjgc1lH1BQS59ustvdAeajObIAA== X-Received: by 2002:a05:6a20:8f15:b0:137:293b:f9c0 with SMTP id b21-20020a056a208f1500b00137293bf9c0mr3542725pzk.33.1689967756135; Fri, 21 Jul 2023 12:29:16 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id i14-20020a63bf4e000000b0054ff36967f7sm3181162pgo.54.2023.07.21.12.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 12:29:15 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qMvoP-003IF4-QK; Fri, 21 Jul 2023 16:29:13 -0300 Date: Fri, 21 Jul 2023 16:29:13 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range_end() Message-ID: References: <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 06:39:26PM +1000, Alistair Popple wrote: > Secondary TLBs are now invalidated from the architecture specific TLB > invalidation functions. Therefore there is no need to explicitly > notify or invalidate as part of the range end functions. This means we > can remove mmu_notifier_invalidate_range_end_only() and some of the > ptep_*_notify() functions. > > Signed-off-by: Alistair Popple > --- > include/linux/mmu_notifier.h | 56 +------------------------------------ > kernel/events/uprobes.c | 2 +- > mm/huge_memory.c | 25 ++--------------- > mm/hugetlb.c | 1 +- > mm/memory.c | 8 +---- > mm/migrate_device.c | 9 +----- > mm/mmu_notifier.c | 25 ++--------------- > mm/rmap.c | 40 +-------------------------- > 8 files changed, 14 insertions(+), 152 deletions(-) Reviewed-by: Jason Gunthorpe Jason