From: Gao Xiang <xiang@kernel.org>
To: Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] erofs: boost negative xattr lookup with bloom filter
Date: Sat, 22 Jul 2023 15:46:56 +0800 [thread overview]
Message-ID: <ZLuJcKH3ymLEVQec@debian> (raw)
In-Reply-To: <bf48239c-6850-d33d-e7f6-1a4a15400ae9@linux.alibaba.com>
On Sat, Jul 22, 2023 at 03:33:11PM +0800, Jingbo Xu wrote:
...
> >> + uint32_t hashbit;
> >
> > Why using `uint32_t` here rather than `unsigned int`? We don't use
> > `uint32_t` in the kernel codebase.
> >
>
> xxh32() returns uint32_t.
we never use (u)intxx_t in the native kernel code.
Thanks,
Gao Xiang
prev parent reply other threads:[~2023-07-22 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:49 [PATCH v5 0/2] erofs: introduce xattr name bloom filter Jingbo Xu
2023-07-21 10:49 ` [PATCH v5 1/2] erofs: update on-disk format for xattr name filter Jingbo Xu
2023-07-21 10:49 ` [PATCH v5 2/2] erofs: boost negative xattr lookup with bloom filter Jingbo Xu
2023-07-22 7:05 ` Gao Xiang
2023-07-22 7:33 ` Jingbo Xu
2023-07-22 7:46 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLuJcKH3ymLEVQec@debian \
--to=xiang@kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox