* [PATCH] firmware: coreboot: framebuffer: Allow building with simpledrm
@ 2023-07-25 17:43 Alper Nebi Yasak
2023-07-25 18:02 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Alper Nebi Yasak @ 2023-07-25 17:43 UTC (permalink / raw)
To: linux-kernel, Greg Kroah-Hartman
Cc: Jack Rosenthal, Douglas Anderson, Dmitry Torokhov, Brian Norris,
coreboot, Guenter Roeck, Stephen Boyd, Wei-Ning Huang,
Julius Werner, Samuel Holland, Alper Nebi Yasak
The coreboot framebuffer driver registers a "simple-framebuffer" device
based on the information from the firmware, after checking that it's
compatible with the formats listed in simplefb.h. It was added before
simpledrm, and its Kconfig marked as dependent on the simplefb driver.
The simpledrm driver can also handle "simple-framebuffer" devices and
the coreboot framebuffer works fine with it on a 'Lick' Chromebook.
Allow building the coreboot framebuffer driver with simpledrm as well.
Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
---
drivers/firmware/google/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index 1bc7cbf2f65d..41b78f5cb735 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -59,7 +59,7 @@ config GOOGLE_MEMCONSOLE_X86_LEGACY
config GOOGLE_FRAMEBUFFER_COREBOOT
tristate "Coreboot Framebuffer"
- depends on FB_SIMPLE
+ depends on FB_SIMPLE || DRM_SIMPLEDRM
depends on GOOGLE_COREBOOT_TABLE
help
This option enables the kernel to search for a framebuffer in
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: coreboot: framebuffer: Allow building with simpledrm
2023-07-25 17:43 [PATCH] firmware: coreboot: framebuffer: Allow building with simpledrm Alper Nebi Yasak
@ 2023-07-25 18:02 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2023-07-25 18:02 UTC (permalink / raw)
To: Alper Nebi Yasak
Cc: linux-kernel, Greg Kroah-Hartman, Jack Rosenthal,
Douglas Anderson, Dmitry Torokhov, coreboot, Guenter Roeck,
Stephen Boyd, Wei-Ning Huang, Julius Werner, Samuel Holland
(administrative note: I doubt coreboot@coreboot.org is interested in
receiving linux kernel driver patches)
On Tue, Jul 25, 2023 at 08:43:33PM +0300, Alper Nebi Yasak wrote:
> The coreboot framebuffer driver registers a "simple-framebuffer" device
> based on the information from the firmware, after checking that it's
> compatible with the formats listed in simplefb.h. It was added before
> simpledrm, and its Kconfig marked as dependent on the simplefb driver.
>
> The simpledrm driver can also handle "simple-framebuffer" devices and
> the coreboot framebuffer works fine with it on a 'Lick' Chromebook.
> Allow building the coreboot framebuffer driver with simpledrm as well.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-25 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 17:43 [PATCH] firmware: coreboot: framebuffer: Allow building with simpledrm Alper Nebi Yasak
2023-07-25 18:02 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).