From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD00CC0015E for ; Wed, 26 Jul 2023 04:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbjGZEzr (ORCPT ); Wed, 26 Jul 2023 00:55:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbjGZEzm (ORCPT ); Wed, 26 Jul 2023 00:55:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8227019AD for ; Tue, 25 Jul 2023 21:55:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 202E36145A for ; Wed, 26 Jul 2023 04:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2E3C433C7; Wed, 26 Jul 2023 04:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690347339; bh=jOeF8cppzlPBCIFSmBztXHTHPsxcIlXUKSUY753sPaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cxwcE7OfXPa1gb3qMiUZj/lC1U5j/C1r691UiAJQVkcVVAudxFcwtAGx8Wu2AcBnB 8lw24oou0sqv8AzGPDJFOusy7EgHHBLa0o5YKEMRCYKB89vjV3tpZvC17ICy6u/8X6 wk9O06Fvrp3aj5VQ4wyFnph/ve5zGaqkPJNX5ABraRKfX98byGF+KGkHOPeLYldO83 LJguFqCyv0CZWxH63HcSnPxUnB+xQo2/ZUImevvR5gtdveNs84BRWD/GnRadRWkB03 xjDYrOn/ZU721oOo2Pfgdaa1cWGeddodXaPNYVMwVN/JG2S9oD+Y1Nz2p6/u6fUTNP VKL7rm/ov1IpQ== Date: Wed, 26 Jul 2023 10:25:35 +0530 From: Vinod Koul To: Robert Lee Cc: Takashi Iwai , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: compress: add opus codec define Message-ID: References: <20230725093005.3499455-1-lerobert@google.com> <87sf9ctifg.wl-tiwai@suse.de> <87lef4thir.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26-07-23, 09:47, Robert Lee wrote: Please stop top posting! > Yes, but we still need this change to let the sound system can use the > codec. or do you have any suggestions? Upstream your driver along with this change should be the way to go > > Thanks, > Robert. > > Takashi Iwai 於 2023年7月25日 週二 下午6:25寫道： > > > > On Tue, 25 Jul 2023 12:14:56 +0200, > > Robert Lee wrote: > > > > > > Thanks for reply so quickly. > > > And yes, there are other changes but it is inside our offload pcm > > > driver to handle it. > > > Currently we only use it to decode, and we don't need additional option for it. > > > > It means still a downstream-only change :) > > > > It's nice to upstream changes in general, but from the upstream POV, > > only changing this gives no benefit. Let's tie with the actual use > > case *in the upstream*. > > > > > > thanks, > > > > Takashi > > > > > > > > Thanks, > > > Robert. > > > > > > Takashi Iwai 於 2023年7月25日 週二 下午6:05寫道： > > > > > > > > On Tue, 25 Jul 2023 11:30:05 +0200, > > > > Robert Lee wrote: > > > > > > > > > > Add to support decode Opus codec in Ogg container. > > > > > > > > > > Signed-off-by: Robert Lee > > > > > > > > The change makes sense only when it's really used. So usually it's > > > > better to put into a series that actually implements its usage. > > > > > > > > > > > > thanks, > > > > > > > > Takashi > > > > > > > > > --- > > > > > include/uapi/sound/compress_params.h | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > > > > > index ddc77322d571..bac5797bcb02 100644 > > > > > --- a/include/uapi/sound/compress_params.h > > > > > +++ b/include/uapi/sound/compress_params.h > > > > > @@ -43,7 +43,8 @@ > > > > > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E) > > > > > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F) > > > > > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010) > > > > > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE > > > > > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011) > > > > > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS > > > > > > > > > > /* > > > > > * Profile and modes are listed with bit masks. This allows for a > > > > > -- > > > > > 2.41.0.487.g6d72f3e995-goog > > > > > > > > -- ~Vinod