From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF64C001DC for ; Wed, 26 Jul 2023 10:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233846AbjGZKaS (ORCPT ); Wed, 26 Jul 2023 06:30:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjGZKaO (ORCPT ); Wed, 26 Jul 2023 06:30:14 -0400 Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6711F2122 for ; Wed, 26 Jul 2023 03:30:12 -0700 (PDT) Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-4864b490e2dso320474e0c.1 for ; Wed, 26 Jul 2023 03:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; t=1690367411; x=1690972211; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=CTp3lWOa4enqnnJtPatmpsbCOMEyt2QR5UoDl0egg08=; b=U53wjrNbnX2OBR176Yur6xYn3E/JYdgMSR+16BeKehlz0f5fhbA4/Eg+atl6iREs1s 3hd1bGwS0oYOzjB09zMamrTE4lmrgLW5QinZEx0HkqXXHB6+U0DeoMK4QtsOMtoslD42 1m2x7JeviSkT+6a0DDmtk3352V5vC2zODwSo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690367411; x=1690972211; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CTp3lWOa4enqnnJtPatmpsbCOMEyt2QR5UoDl0egg08=; b=BxwZCtMjS7cmJQ7MYMjcwvqyhoy/G2GT0iknMlSyMcBmt1dPpkDsa459KY15TD2siR 8SVGX7mnhKevkbFmTrcuGukCmysOyNBmbZeLhozODy1496q2L2MxP6Gr9FDc9trGyz3s G9GwzcWjJuFmydsoJ4Ayi1wqMb9bn0fTNEpFiTU7R0Vq3BhciCWStxhd8ivWPaSHzMfe KJjz4bzaQns9MQ3Ltz9ey/mDnPmcv8sswP6ScT+1DLioTUd7tpJhgOyOfizqfsEOrFEQ ZA2UXs2h8uY0rfiz6J9IYjq4/2h3IziWqW6U0x4i3ILXQXqQhc+v1YaRigTURM5ROpNQ ql+Q== X-Gm-Message-State: ABy/qLaIpngd0LtUqrbGFhU5N2klUtfEfwQKU27UQZWWzQzLwaDk/SCt whDqOVWRDlOmA9RmZ4FBsq57XKVtZoc+G0uZWyGL3Q== X-Google-Smtp-Source: APBJJlHQAi72WGV2GbGe8wvaVLOW245nW2auiZg9IEQZ6jnW7cUxgb+TrfgWpmozA/5rJdkpi3JzsQ== X-Received: by 2002:a1f:4ac4:0:b0:46e:7558:a45c with SMTP id x187-20020a1f4ac4000000b0046e7558a45cmr836922vka.8.1690367411455; Wed, 26 Jul 2023 03:30:11 -0700 (PDT) Received: from debian.debian ([140.141.197.139]) by smtp.gmail.com with ESMTPSA id h9-20020a0cab09000000b0063019b482f8sm1479020qvb.85.2023.07.26.03.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 03:30:10 -0700 (PDT) Date: Wed, 26 Jul 2023 03:30:08 -0700 From: Yan Zhai To: Markus Elfring Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Hao Luo , Jakub Kicinski , Jakub Sitnicki , Jiri Olsa , John Fastabend , Jordan Griege , KP Singh , LKML , Martin KaFai Lau , Mykola Lysenko , Paolo Abeni , Shuah Khan , Song Liu , Stanislav Fomichev , Yonghong Song , bpf@vger.kernel.org, kernel-janitors@vger.kernel.org, kernel-team@cloudflare.com, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 bpf 2/2] bpf: selftests: add lwt redirect regression test cases Message-ID: References: <9c4896b109a39c3fa088844addaa1737a84bbbb5.1690332693.git.yan@cloudflare.com> <3ec61192-c65c-62cc-d073-d6111b08e690@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Apologize for sending previous mail from a wrong app (not text mode). Resending to keep the mailing list thread consistent. On Wed, Jul 26, 2023 at 3:10 AM Markus Elfring wrote: > > > Tests BPF redirect at the lwt xmit hook to ensure error handling are > > safe, i.e. won't panic the kernel. > > Are imperative change descriptions still preferred? Hi Markus, I think you linked this to me yesterday that it should be described imperatively: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n155 > > See also: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94 > I don’t follow the purpose of this reference. This points to user impact but this is a selftest, so I don’t see any user impact here. Or is there anything I missed? > > Can remaining wording weaknesses be adjusted accordingly? I am not following this question . Can you be more specific or provide an example? Yan > > Regards, > Markus >