From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 1/6] bitmap: fix opencoded bitmap_allocate_region()
Date: Thu, 27 Jul 2023 13:04:07 +0300 [thread overview]
Message-ID: <ZMJBF8rEKCSpij+D@smile.fi.intel.com> (raw)
In-Reply-To: <20230727020207.36314-2-yury.norov@gmail.com>
On Wed, Jul 26, 2023 at 07:02:02PM -0700, Yury Norov wrote:
> bitmap_find_region() opencodes bitmap_allocate_region(). Fix it.
...
> + for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end)
In the other patch you use BIT(order), why not here?
> + if (!bitmap_allocate_region(bitmap, pos, order))
> + return pos;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-27 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 2:02 [PATCH 0/6] bitmap: cleanup bitmap_*_region() implementation Yury Norov
2023-07-27 2:02 ` [PATCH 1/6] bitmap: fix opencoded bitmap_allocate_region() Yury Norov
2023-07-27 10:04 ` Andy Shevchenko [this message]
2023-07-27 2:02 ` [PATCH 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set() Yury Norov
2023-07-27 2:02 ` [PATCH 3/6] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear() Yury Norov
2023-07-27 2:02 ` [PATCH 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit() Yury Norov
2023-07-27 10:05 ` Andy Shevchenko
2023-07-27 2:02 ` [PATCH 5/6] bitmap: drop _reg_op() function Yury Norov
2023-07-27 2:02 ` [PATCH 6/6] bitmap: move bitmap_*_region functions to bitmap.h Yury Norov
2023-07-27 5:09 ` kernel test robot
2023-07-27 5:20 ` kernel test robot
2023-07-27 10:06 ` Andy Shevchenko
2023-07-27 14:39 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJBF8rEKCSpij+D@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox