From: Andy Shevchenko <andy@kernel.org>
To: Romain Perier <romain.perier@gmail.com>
Cc: Andrei Coardos <aboutphysycs@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, brgl@bgdev.pl,
linus.walleij@linaro.org, daniel@thingy.jp,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata()
Date: Thu, 27 Jul 2023 13:09:19 +0300 [thread overview]
Message-ID: <ZMJCT0jtCzUuSnQP@smile.fi.intel.com> (raw)
In-Reply-To: <CABgxDoL4ftygpXKKuRoAKJ41KRTLQZr-YOiWLC5pM96-qe_=eQ@mail.gmail.com>
On Thu, Jul 27, 2023 at 09:00:36AM +0200, Romain Perier wrote:
First of all, please do not top-post!
> The private data is "struct msc313_gpio *gpio". This private data is
> "binded" to the gpio_chip via devm_gpiochip_add_data, right ?
No.
> Then it is retrieved via gpiochip_get_data(chip), right ?
No.
The driver data is used in PM callbacks. See below.
> Le mar. 25 juil. 2023 à 15:22, Andy Shevchenko <andy@kernel.org> a écrit :
> >
> > On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> > > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > > > This function call was found to be unnecessary as there is no equivalent
> > > > platform_get_drvdata() call to access the private data of the driver.
> >
> > Not true.
^^^^
> > > > Also, the private data is defined in this driver, so there is no risk of
> > > > it being accessed outside of this driver file.
> > >
> > > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >
> > I have to withdraw this, the patch is wrong.
> > NAK.
> >
> > Sorry for the confusion (I have looked for the wrong pattern).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-27 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:11 [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata() Andrei Coardos
2023-07-21 16:14 ` Andy Shevchenko
2023-07-25 13:19 ` Andy Shevchenko
2023-07-27 7:00 ` Romain Perier
2023-07-27 10:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJCT0jtCzUuSnQP@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox