From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: kevin.tian@intel.com, yi.l.liu@intel.com, joro@8bytes.org,
will@kernel.org, robin.murphy@arm.com,
alex.williamson@redhat.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
mjrosato@linux.ibm.com, farman@linux.ibm.com
Subject: Re: [PATCH v9 2/6] iommufd: Allow passing in iopt_access_list_id to iopt_remove_access()
Date: Thu, 27 Jul 2023 11:34:39 -0300 [thread overview]
Message-ID: <ZMKAfw02spcSIrcG@nvidia.com> (raw)
In-Reply-To: <bb3c6845bc64209ae4dca5ee0dc87464fbc4961e.1690440730.git.nicolinc@nvidia.com>
On Thu, Jul 27, 2023 at 12:23:07AM -0700, Nicolin Chen wrote:
> This is a preparatory change for ioas replacement support for access.
> The replacement routine does an iopt_add_access() at a new IOAS first
> and then iopt_remove_access() at the old IOAS upon the success of the
> first call. However, the first call overrides the iopt_access_list_id
> in the access struct, resulting in that id un-erased in the xarray.
>
> Add an iopt_access_list_id in iopt_remove_access, so the replacement
> routine can save the id before it gets overwritten, and pass the id
> in iopt_remove_access() for a proper cleanup.
>
> The existing callers should just pass in access->iopt_access_list_id.
>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/iommufd/device.c | 6 ++++--
> drivers/iommu/iommufd/io_pagetable.c | 6 +++---
> drivers/iommu/iommufd/iommufd_private.h | 3 ++-
> 3 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2023-07-27 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 7:23 [PATCH v9 0/6] cover-letter: Add IO page table replacement support Nicolin Chen
2023-07-27 7:23 ` [PATCH v9 1/6] vfio: Do not allow !ops->dma_unmap in vfio_pin/unpin_pages() Nicolin Chen
2023-07-27 7:23 ` [PATCH v9 2/6] iommufd: Allow passing in iopt_access_list_id to iopt_remove_access() Nicolin Chen
2023-07-27 9:07 ` Nicolin Chen
2023-07-27 14:34 ` Jason Gunthorpe [this message]
2023-07-27 7:23 ` [PATCH v9 3/6] iommufd: Add iommufd_access_change_ioas helper Nicolin Chen
2023-07-27 14:40 ` Jason Gunthorpe
2023-07-27 18:47 ` Nicolin Chen
2023-07-27 7:23 ` [PATCH v9 4/6] iommufd: Add iommufd_access_replace() API Nicolin Chen
2023-07-27 7:23 ` [PATCH v9 5/6] iommufd/selftest: Add IOMMU_TEST_OP_ACCESS_REPLACE_IOAS coverage Nicolin Chen
2023-07-27 7:23 ` [PATCH v9 6/6] vfio: Support IO page table replacement Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMKAfw02spcSIrcG@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox