From: kernel test robot <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Caleb Connolly <caleb.connolly@linaro.org>
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Subject: drivers/power/supply/qcom_pmi8998_charger.c:565 smb2_status_change_work() error: uninitialized symbol 'usb_online'.
Date: Fri, 28 Jul 2023 08:45:44 +0300 [thread overview]
Message-ID: <ZMNWCD66TAhahJ2Y@kadam> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 57012c57536f8814dec92e74197ee96c3498d24e
commit: 8648aeb5d7b70e13264ff5f444f22081d37d4670 power: supply: add Qualcomm PMI8998 SMB2 Charger driver
config: arm-randconfig-m041-20230727 (https://download.01.org/0day-ci/archive/20230728/202307280638.556PrzIS-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230728/202307280638.556PrzIS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202307280638.556PrzIS-lkp@intel.com/
smatch warnings:
drivers/power/supply/qcom_pmi8998_charger.c:565 smb2_status_change_work() error: uninitialized symbol 'usb_online'.
vim +/usb_online +565 drivers/power/supply/qcom_pmi8998_charger.c
8648aeb5d7b70e Caleb Connolly 2023-05-26 556 static void smb2_status_change_work(struct work_struct *work)
8648aeb5d7b70e Caleb Connolly 2023-05-26 557 {
8648aeb5d7b70e Caleb Connolly 2023-05-26 558 unsigned int charger_type, current_ua;
8648aeb5d7b70e Caleb Connolly 2023-05-26 559 int usb_online, count, rc;
8648aeb5d7b70e Caleb Connolly 2023-05-26 560 struct smb2_chip *chip;
8648aeb5d7b70e Caleb Connolly 2023-05-26 561
8648aeb5d7b70e Caleb Connolly 2023-05-26 562 chip = container_of(work, struct smb2_chip, status_change_work.work);
8648aeb5d7b70e Caleb Connolly 2023-05-26 563
8648aeb5d7b70e Caleb Connolly 2023-05-26 564 smb2_get_prop_usb_online(chip, &usb_online);
This can only happen if regmap_read() fails, and in real life they
can't actually fail can they? We can't really recover if regmap
breaks so in that situation this uninitialized variable would be the
least of our concerns. Right?
So what I could do is just delete the regmap_read error paths from
the DB. I just add these two lines to smatch_data/db/kernel.delete.return_states
regmap_read (-22)
regmap_read (-4095)-(-1)
8648aeb5d7b70e Caleb Connolly 2023-05-26 @565 if (!usb_online)
^^^^^^^^^^
8648aeb5d7b70e Caleb Connolly 2023-05-26 566 return;
8648aeb5d7b70e Caleb Connolly 2023-05-26 567
8648aeb5d7b70e Caleb Connolly 2023-05-26 568 for (count = 0; count < 3; count++) {
8648aeb5d7b70e Caleb Connolly 2023-05-26 569 dev_dbg(chip->dev, "get charger type retry %d\n", count);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-07-28 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 5:45 kernel test robot [this message]
2023-08-02 13:19 ` drivers/power/supply/qcom_pmi8998_charger.c:565 smb2_status_change_work() error: uninitialized symbol 'usb_online' Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMNWCD66TAhahJ2Y@kadam \
--to=dan.carpenter@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox