From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rob Herring <robh@kernel.org>
Cc: John Crispin <john@phrozen.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: More explicit DT include clean-ups
Date: Fri, 28 Jul 2023 11:48:44 +0200 [thread overview]
Message-ID: <ZMOO/AIP25sxRXHY@alpha.franken.de> (raw)
In-Reply-To: <20230727012040.3934021-1-robh@kernel.org>
On Wed, Jul 26, 2023 at 07:20:39PM -0600, Rob Herring wrote:
> A couple more clean-ups in the MIPS code.
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it was merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> I've now built all MIPS defconfigs in my tree which removes the implicit
> includes. So I found a few more fixes. This can be squashed into the
> previous commit if desired.
> ---
> arch/mips/cavium-octeon/octeon-platform.c | 2 ++
> arch/mips/cavium-octeon/octeon-usb.c | 2 ++
> arch/mips/ralink/ill_acc.c | 2 ++
> 3 files changed, 6 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-07-28 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 1:20 [PATCH] MIPS: More explicit DT include clean-ups Rob Herring
2023-07-28 9:48 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMOO/AIP25sxRXHY@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox