From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CF9C0015E for ; Fri, 28 Jul 2023 14:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237281AbjG1OyS (ORCPT ); Fri, 28 Jul 2023 10:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjG1OyQ (ORCPT ); Fri, 28 Jul 2023 10:54:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9334F12D; Fri, 28 Jul 2023 07:54:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 303056217F; Fri, 28 Jul 2023 14:54:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C5C3C433C7; Fri, 28 Jul 2023 14:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690556054; bh=R9op8pPpmsKkCoqmTa7kyILBaKx3qjkB+WKspxSkx40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qAbPllgiag0JHhACI1BZnqart2OdDDXqYcHTpHOQj3SCt1iDM8OLCW0nwB1ETdBkY mW4lutGWRjORuLx3M+L1to6wA7cZb3hFtA8P3imJIxuxoiYWD1EKhT9aKv43fuSIPK o9EHbV6ZlTb5PfxS9hKxjTB5Tzqy9t7zMjtSix6d0bypSRygrmgCb1pGt3eCvpIrDV 4mSJqVgH8fsBaSrjPG6aqCpFdZOLzyoEOjF2zu7I0Wa76+MEzXXRwfesGoRfvDcbUt DprSrK41ByXxrMZIP8f4v9PEshuQMvVePtiXGcjhsOxTZNPwiBfUjh9N8pS5ibdM78 B8Dx0laG5GL4Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BBCF640096; Fri, 28 Jul 2023 11:54:11 -0300 (-03) Date: Fri, 28 Jul 2023 11:54:11 -0300 From: Arnaldo Carvalho de Melo To: Aditya Gupta Cc: jolsa@kernel.org, irogers@google.com, namhyung@kernel.org, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support Message-ID: References: <20230725061649.34937-1-adityag@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725061649.34937-1-adityag@linux.ibm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > Currently we depend on output of 'perf record -e "sched:sched_switch"', to > check whether perf was built with libtraceevent support. > > Instead, a more straightforward approach can be to check the build options, > using 'perf version --build-options', to check for libtraceevent support. > > When perf is compiled WITHOUT libtraceevent ('make NO_LIBTRACEEVENT=1'), > 'perf version --build-options' outputs (output trimmed): > > ... > libtraceevent: [ OFF ] # HAVE_LIBTRACEEVENT > ... > > While, when perf is compiled WITH libtraceevent, > > 'perf version --build-options' outputs: > > ... > libtraceevent: [ on ] # HAVE_LIBTRACEEVENT > ... > > Suggested-by: Ian Rogers > Signed-off-by: Aditya Gupta > --- > > tools/perf/tests/shell/test_task_analyzer.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh > index 0095abbe20ca..a28d784987b4 100755 > --- a/tools/perf/tests/shell/test_task_analyzer.sh > +++ b/tools/perf/tests/shell/test_task_analyzer.sh > @@ -52,7 +52,7 @@ find_str_or_fail() { > > # check if perf is compiled with libtraceevent support > skip_no_probe_record_support() { > - perf record -e "sched:sched_switch" -a -- sleep 1 2>&1 | grep "libtraceevent is necessary for tracepoint support" && return 2 > + perf version --build-options | grep HAVE_LIBTRACEEVENT | grep -q OFF && return 2 > return 0 I'll apply this, but please consider adding a: perf build --has libtraceevent subcommand to have that query made more compact and to avoid the two extra grep. BTW, I'll change that to: [acme@quaco perf-tools-next]$ perf version --build-options | grep " on .* HAVE_LIBTRACEEVENT" libtraceevent: [ on ] # HAVE_LIBTRACEEVENT [acme@quaco perf-tools-next]$ replacing "on" with OFF, so that we have just one grep. Thanks, - Arnaldo > } > > -- > 2.41.0 > -- - Arnaldo